Giter Club home page Giter Club logo

Comments (11)

Zeblote avatar Zeblote commented on September 26, 2024 1

A better fix would be to remove the unused variable or ignore that specific warning: -Wno-unused-but-set-variable

from physx.

LordOfDragons avatar LordOfDragons commented on September 26, 2024

There are many such places with unused variables. Trying to fix them all would be a chore. Needs a fix upstream or allowing to disable this warning for release builds.

Opting for proper fix though. I always build with Wall Werror and just can't understand how such things can end up in a release.

from physx.

Zeblote avatar Zeblote commented on September 26, 2024

There were recent changes to the behavior of unused-but-set-variable, to warn in additional cases, so maybe they only tested PhysX with an older compiler version.

from physx.

jcarius-nv avatar jcarius-nv commented on September 26, 2024

Please see https://github.com/NVIDIA-Omniverse/PhysX/blob/release/104.1/physx/documentation/platformreadme/linux/README_LINUX.md for supported platforms and compiler versions, in your case that would be

    Ubuntu 20.04 LTS with gcc 9 or clang 10
    Ubuntu 22.04 LTS with gcc 11 or clang 14

For anything newer I'm afraid we can't guarantee that it just works out of the box. As @Zeblote mentions, you're free to disable the warning.

from physx.

LordOfDragons avatar LordOfDragons commented on September 26, 2024

Using "gcc 11.3.1" here and it causes many warnings failing to build. According to your statement gcc 11 is supported and should work so in my opinion this is a clear bug then... unless I'm misunderstanding something here.

from physx.

jcarius-nv avatar jcarius-nv commented on September 26, 2024

@LordOfDragons It should build, yes. Can you share some more details about your setup, and the build log that shows the compiler invocation and the error?

from physx.

LordOfDragons avatar LordOfDragons commented on September 26, 2024

Which file are you looking for?

from physx.

jcarius-nv avatar jcarius-nv commented on September 26, 2024

Similar to the information that was provided in #25, i.e., the exact error message and the gcc command that make is calling so we can see all the flags passed to it.
I think you should be able to read all that in the console log if you run make VERBOSE=1

from physx.

LordOfDragons avatar LordOfDragons commented on September 26, 2024

I can't find any file mentioned there to post so I piped the console output into a file: https://pastebin.com/1t4CFGJA . I do though not see the compile parameters in there so is there some kind of log file written which contains this information? As you can see I've modified the build files to not raise an error for each warning which is why you can see all of the problems.

And output of "g++ --version"
g++ (Gentoo 11.3.1_p20221209 p3) 11.3.1 20221209

from physx.

jcarius-nv avatar jcarius-nv commented on September 26, 2024

interesting, it appears that the same minor version of gcc behaves differently on different linux flavors (?!).
I just checked again and can confirm that we're testing on gcc (Ubuntu 11.3.0-1ubuntu1~22.04) 11.3.0

from physx.

LordOfDragons avatar LordOfDragons commented on September 26, 2024

Well... there is a small difference (11.3.1 -> 11.3.0) but I don't think that's to blame.

from physx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.