Giter Club home page Giter Club logo

Comments (10)

szepeviktor avatar szepeviktor commented on May 9, 2024 6

Free falling is my favorite.

from phpinsights.

dingo-d avatar dingo-d commented on May 9, 2024 1

Yup, noticed that there is a default exclusion list. I'll try to debug why the scan fails on non-bedrock projects.

from phpinsights.

szepeviktor avatar szepeviktor commented on May 9, 2024

Could we name the folder WordPress?

from phpinsights.

nunomaduro avatar nunomaduro commented on May 9, 2024

Sure, done! Do you work with WordPress buddy?

from phpinsights.

szepeviktor avatar szepeviktor commented on May 9, 2024

Yes, I run Laravel and WordPress sites.

from phpinsights.

nunomaduro avatar nunomaduro commented on May 9, 2024

Nice! Fell free to work in this issue. Should be easy. You can check the example within the Symfony repository.

from phpinsights.

killua99 avatar killua99 commented on May 9, 2024

I'm trying to build the Preset for it. I'm getting few errors not quite sure why, perhaps you could provide some help with these

PHP Fatal error:  Uncaught TypeError: Argument 2 passed to SlevomatCodingStandard\Helpers\FunctionHelper::getParametersTypeHints() must be of the type integer, null given, called in /Volumes/Projects/www/xxxxx.com.dev.synot.io/site/vendor/slevomat/coding-standard/SlevomatCodingStandard/Sniffs/TypeHints/DisallowArrayTypeHintSyntaxSniff.php on line 150 and defined in /Volumes/Projects/www/xxx.com.dev.synot.io/site/vendor/slevomat/coding-standard/SlevomatCodingStandard/Helpers/FunctionHelper.php:143

from phpinsights.

dingo-d avatar dingo-d commented on May 9, 2024

Yeah, I can confirm that running this as is in a WordPress project will fail on the PHPCS sniffs

PHP Fatal error:  Cannot declare class PHPCompatibility\Sniffs\FunctionUse\RequiredToOptionalFunctionParametersSniff, because the name is already in use in my-project/vendor/phpcompatibility/php-compatibility/PHPCompatibility/Sniffs/FunctionUse/RequiredToOptionalFunctionParametersSniff.php on line 0

Fatal error: Cannot declare class PHPCompatibility\Sniffs\FunctionUse\RequiredToOptionalFunctionParametersSniff, because the name is already in use in my-project/vendor/phpcompatibility/php-compatibility/PHPCompatibility/Sniffs/FunctionUse/RequiredToOptionalFunctionParametersSniff.php on line 0

Not sure if vendor folder should be included or not when running the checks, also not sure if this can be applied to WordPress, because it's not a framework that you can install using composer (officially).

If an adapter would be created, it could work only with johnpbloch/wordpress or roots/wordpress used in Bedrock.

from phpinsights.

olivernybroe avatar olivernybroe commented on May 9, 2024

@dingo-d The vendor folder should be excluded, however we should already have code that does this.
We don't scan the vendor folder, as that is not code you have written.

Not a wordpress user myself, could somebody look into the PR?

from phpinsights.

nunomaduro avatar nunomaduro commented on May 9, 2024

No plans to work on this at this time. Feel free to make a pull request with this feature.

from phpinsights.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.