Making `Constraint.Description` abstract breaks backwards compatibility about nunit HOT 5 CLOSED

I completely understand the rationale. Fixing stuff that feels wrong is what major versions are there for. I'll try to ensure the xmlunit-nunit3-constraints library is going to work with NUnit 4.x as well and create a nunit4 one if that is necessary. Right now that doesn't seem to be the case as the libraries really only provide new Constraints..

Thank you!

from nunit.

It was done as part of a huge effort to make the library honor nullability, and also clean up some practices. The property should be read-only with the implemented class defining the value. I believe that was the reason. @manfred-brands , can you add to this ?

And sure, it should be listed.
Actually we might have some more of these, so thanks for alerting us on this one!

from nunit.

@OsirisTerje Yes this was done for nullability changes. The previous design relied on a derived class calling the protected setter which could not be guaranteed. It was either marking the property as nullable and add lots of tests on null or make it virtual and non-nullable. . As it is used in places like: Left.Description + " and " + Right.Description I choose for the latter.

For the same reason a change was made in the PrefixConstraint. Instead of relying on a derived class setting the DescriptionPrefix this now must be passed in to the PrefixContraint constructor.

from nunit.

Thanks @manfred-brands ! That added some more context to it.

@bodewig We'll add it to the release notes :-)

from nunit.

Fixing with PR nunit/docs#916

from nunit.