Giter Club home page Giter Club logo

Comments (8)

NullVoxPopuli avatar NullVoxPopuli commented on May 29, 2024

Thanks for reporting!

Could be an oversight
I think a previous iteration of this did split up the install to be after cache setup.
Here: https://github.com/NullVoxPopuli/action-setup-pnpm/blob/v1.1.0/action.yml#L35

So maybe that needs to come back

from action-setup-pnpm.

NullVoxPopuli avatar NullVoxPopuli commented on May 29, 2024

Here is the PR that probably needs a revert with a tweak: https://github.com/NullVoxPopuli/action-setup-pnpm/pull/12/files

We want the new simpler way of handling args, but with post-cache install

from action-setup-pnpm.

patricklx avatar patricklx commented on May 29, 2024

maybe you can just switch actions/setup-node@v3 <-> pnpm/action-setup@v2 ?

from action-setup-pnpm.

NullVoxPopuli avatar NullVoxPopuli commented on May 29, 2024

Does that one respect volta node?
Also, seems unrelated to cache?

from action-setup-pnpm.

patricklx avatar patricklx commented on May 29, 2024

i just mean the ordering

from action-setup-pnpm.

NullVoxPopuli avatar NullVoxPopuli commented on May 29, 2024

This is the recommended way to use cache: https://github.com/pnpm/action-setup#use-cache-to-reduce-installation-time

Should probably align with that

from action-setup-pnpm.

patricklx avatar patricklx commented on May 29, 2024

okay. then the only way is to run pnpm install manually...
also, that seems to be the recommended way :) run_install: false and pnpm install at end

from action-setup-pnpm.

NullVoxPopuli avatar NullVoxPopuli commented on May 29, 2024

Yup, i'll happily accept a pr here, and i can port it to wyvox

from action-setup-pnpm.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.