Handler hangs when processing upgrade request about ntex HOT 7 CLOSED

interesting. i wont be able to check until weekend, maybe next week. but something is definitely not right

from ntex.

this problem is fixed in master. but you have to use web::ws::start or write response directly to io, h1 dispatcher cannot do anything when handler is in ws upgrade mode.

from ntex.

Thanks @fafhrd91 for fixing this!

There is an edge case, although. It's impossible to reject an upgrade request by sending non-101 response with a body.
I'm getting error Stream responses are not supported for upgrade requests.
With response header
Connection: upgrade
which seems wrong.

Basically this error would appear for any normal (non-websocket) handlers when sending upgrade requests.
Is this expected?

from ntex.

i think this is bug, h1 dispatcher should not try write response. i will check

from ntex.

Maybe I'm wrong, but should dispatcher continue working as usual for all types of requests (upgrade and non-upgrade) when underlying IO wasn't taken?

ws::start as well as low-level websocket (or connection upgrading) handling requires taking IO object off which makes impossible returning response from handler.

from ntex.

dispatcher is generic over Filter, to pass io to handler F get erased (IoBoxed), it is not possible to restart dispatcher after that

from ntex.

should be fixed in 0.6.5

from ntex.