Comments (8)
fafhrd91
commented on May 27, 2024
1
@ctron would you like to submit pr for this issue?
from ntex-mqtt.
ctron
commented on May 27, 2024
During the handshake, the function simply overwrites the result, coming from the connect handler, with the value from the server:
Line 421 in 828e696
The value in the connect ack is actually an Option.
So me it would make sense to honor the values from the connect ack struct, as long as they are below the server maximum. If the value from connect ack is None, and the server maximum is zero, then None should be set, which would drop the value from the encoded package.
Aside from that, I think the handshake should also honor the other values and not overwrite them:
Lines 422 to 423 in 828e696
from ntex-mqtt.
ctron
commented on May 27, 2024
If you want, I can try coming up with a fix for this.
from ntex-mqtt.
fafhrd91
commented on May 27, 2024
good catch. max size should be omitted if it set to 0
from ntex-mqtt.
fafhrd91
commented on May 27, 2024
I agree regarding topic_alias_max and max_qos
from ntex-mqtt.
fafhrd91
commented on May 27, 2024
fixed in master
from ntex-mqtt.
ctron
commented on May 27, 2024
fixed in master
Thanks! I am sorry I couldn't time for this so far.
from ntex-mqtt.
fafhrd91
commented on May 27, 2024
no problem
from ntex-mqtt.
Related Issues (20)
- Subscribe packet is malformed when a subscription identifier is specified HOT 2
- how to use mpsc::channel to dispatch msg when handle incoming publishes and how to subscribe to multiple topics in one API call? HOT 3
- connect to "broker-cn.emqx.io:8883"/"54.87.92.106:8883" fail by openssl HOT 2
- Expose full MQTT packet length HOT 1
- Possible session leak HOT 3
- How to define return type of `v3::MqttServer::new` HOT 6
- mqtt-ws-server.rs for ws HOT 2
- generic associated types are unstable HOT 1
- unresolved import `crate::rt::Signal` HOT 1
- How to connect using a username and password HOT 2
- not found in `crate::rt` HOT 3
- Compilation failed HOT 4
- mqtt-ws-server.rs ws connection fail
- Issues with keep-alive after updating from 0.9 to 0.12 HOT 17
- Troubles upgrade to 0.8.x HOT 4
- can i used to my server for Distributed MQTT Message Broker HOT 2
- v0.8.3 Linux compilation failed HOT 1
- SubscribeAckReason enum has a typo HOT 2
- PubAckReason enum contains ReceiveMaximumExceeded HOT 1
- Subs.rs example uses .subscribe() which is unlisted in docs as opposed to .confirm() HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ntex-mqtt.