Comments (6)
Thanks for the note, I didn't realize that Semiotic was so closely tied to 15.4 but 15.4.2 is the version referenced in the package.json
, I just didn't realize the PropTypes had changed in between. I'm going to transition it to React 16 over the course of the next couple weeks but I'll see if I can clean this up in the interim.
from semiotic.
So I was digging into this and searching through my code I don't see anywhere where I'm using React.PropTypes
I only see prop types being imported from prop-types
. What version of Semiotic are you using and what was the exact error?
from semiotic.
This is the relevant part of package.json:
"dependencies": {
"d3-scale": "1.0.6",
"d3-shape": "1.2.0",
"d3-svg-legend": "2.24.1",
"react": "15.4.2",
"react-dom": "15.4.2",
"react-scripts": "1.0.14",
"semiotic": "^1.1.0"
},
The exact error... I think it was on _React.PropTypes.number, where _React.PropTypes was undefined.
from semiotic.
I see the reason now, it's the react-annotation
library that is still using React.PropTypes instead of prop-types
. I'll file an issue and update and close this once that's sorted.
from semiotic.
This should be resolved in version 0.0.1-4 please let me know if you have any issues with it.
from semiotic.
This should be resolved in the latest version.
from semiotic.
Related Issues (20)
- Use Vercel to deploy developer documentation for latest HOT 2
- Decide whether to consolidate semiotic and semiotic-docs repo HOT 8
- Check if auto-external plugin can warn us about import errors
- Add to contributing doc when to upgrade dependencies.
- Run typescript checks in CI
- Add documentation issues from archived repo
- oSort with connectors causes issues in OrdinalFrame
- Create changelog for 2.0 HOT 2
- Add Migration Guide for 1.0 users
- Replace element-resize-event HOT 5
- Sorting in OrdinalFrame Doesn't Work With Dynamic Column Width
- Frames' space allocation behavior can be generalized
- Bundled size quite large HOT 3
- Canvas Rendering Doesn't Initially Render HOT 3
- Remove redundant attribute [Was: class and className entries] HOT 1
- Transition tooltip position HOT 1
- More position options for the legend HOT 3
- How to use with nteract?
- Ability to specify width in terms of percentage
- Some of the website pages are fully blank
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from semiotic.