Comments (10)
This is a problem with the Atom API for markers. I've opened an issue at atom/atom#6857 — I need them to fix it before I can address this, unfortunately.
from hydrogen.
Or rather, I could fix it for us, but at risk of breaking other packages (as I mention on that thread). I think it's unlikely that any packages depend on the exact z-index
of the tab bar, so if they don't get a fix done soon I'll just do that.
from hydrogen.
Went ahead and did this. Shipped in v0.4.0
!
from hydrogen.
Thanks Will.
from hydrogen.
This issue is still present in v0.7.1
from hydrogen.
This comment shows the issue clearly.
from hydrogen.
Block decorations should be the way forward. http://blog.atom.io/2016/02/03/introducing-block-decorations.html
from hydrogen.
@rgbkrk I've tried the following with Atom 1.7.0-dev-7040035 and it doesn't seem to work:
$ git diff
diff --git a/lib/main.coffee b/lib/main.coffee
index 7afdb18..10b2ef0 100644
--- a/lib/main.coffee
+++ b/lib/main.coffee
@@ -159,9 +159,9 @@ module.exports = Hydrogen =
view.statusContainer.setAttribute('style', "height: #{lineHeight}px")
@editor.decorateMarker marker,
- type: 'overlay'
+ type: 'block'
item: element
- position: 'tail'
+ position: 'after'
@markerBubbleMap[marker.id] = view
marker.onDidChange (event) =>
diff --git a/styles/hydrogen.less b/styles/hydrogen.less
index 5ba24fa..cd98ed4 100644
--- a/styles/hydrogen.less
+++ b/styles/hydrogen.less
@@ -5,20 +5,6 @@
@import "ui-variables";
@import "syntax-variables";
-// this is a hack to deal with a failing of the markers API
-// https://github.com/atom/atom/issues/6857
-.tab-bar {
- z-index: 5;
-}
-
-.bottom{
- z-index: 4;
-}
-
-atom-overlay.autocomplete-plus {
- z-index: 6;
-}
-
.hydrogen.output-bubble {
@light-bubble-background: fadein(lighten(@syntax-background-color, 40%), 100%);
@dark-bubble-background: fadein(lighten(@syntax-background-color, 10%), 100%);
from hydrogen.
@n-riesco if you remove this line the result should be displayed. But of course the styling will be totally messed up.
from hydrogen.
@lgeiger Here's how it looks like after removing position: absolute
:
from hydrogen.
Related Issues (20)
- hydrogen fails to install on Atom HOT 2
- fialedto activate
- npm WARN deprecated [email protected] HOT 2
- Failed to activate the Hydrogen package HOT 18
- [email protected] failed
- Interactive input in output area
- VSCode: port or alternative HOT 12
- Uncaught Error: Cannot find module 'lodash/debounce'Require stack:- $ATOM_HOME/packages\Hydroge... HOT 3
- Uncaught error: no native build was found for platforms HOT 4
- Please port to Vs Code or any other IDE HOT 1
- Uncaught Error: No native build was found for platform=darwin arch=x64 runtime=electron abi=85 uv... HOT 2
- TypeError when using hydrogen with pulsar HOT 4
- Hi, If the notebook in "not trusted" mode. Just click on it and make it trusted then save the file. It will work fine.
- SCRIPT WONT EXECUTE. HOT 1
- can't rebuild zeromq for pulsar
- Newly installed python modules cannot be found by hydrogen in pulsar
- [18:30] r p npm WARN deprecated [email protected]: this library is no longer supported [18:31] r p npm WARN deprecated [email protected]: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic [18:31] r p npm WARN deprecated [email protected]: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic
- deleted
- Is this going to be maintained? HOT 5
- Publish Hydrogen to Pulsar Package Repository HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hydrogen.