Error when activating charge about shopify HOT 6 CLOSED

@DavidVII I've come across this error before, iirc this is because hackney can not handle a nil value for a post/put body. I fixed that in recent commits, however I haven't been able to do a comprehensive test for those cases.

Can you test your usecase against the master branch? Setting up an application charge just for test cases is a PITA, so if you have everything set up already that would be hugely appreciated 🙏

from shopify.

Thanks, @Ninigi. I am in fact using the latest from the master branch. Is there any particular area of the codebase that comes to mind? I don't mind looking into this as well since I do have an app setup ATM. Let me know.

from shopify.

@DavidVII I just pushed the post body fix (30 mins ago?), so maybe you could update and try again? 😆

from shopify.

@Ninigi haha my bad. Ya, I'll try again. Thanks!

from shopify.

@DavidVII this is the culprit (at least that's my guess for now)

from shopify.

@Ninigi yep looks like that's it. I was able to activate a charge. Interestingly enough, I got an error when deleting a charge. It did, in fact, cancel the charge, but it returned this:

 no case clause matching: {:error, :invalid, 0}
    (shopify) lib/shopify/response.ex:24: Shopify.Response.parse_json/2
    (shopify) lib/shopify/response.ex:12: Shopify.Response.new/3

That probably warrants a separate issue. I'll test it out and see if it's valid.

Thanks for your help, @Ninigi! I'll close this one out for now since it appears that 77fd3aa addresses this issue.

from shopify.