Giter Club home page Giter Club logo

Comments (10)

bradmartin avatar bradmartin commented on May 18, 2024

Well it shouldn't be looking in your app/ folder for the module, it's in node_modules. Did you change the path on the <Page xmlns=""> pointing to the plugin?

from nativescript-videoplayer.

bradmartin avatar bradmartin commented on May 18, 2024

Another thing I never run tns install - I run build then run or livesync to start working.

So it's possible something went wrong during that step and the module never was installed correctly.

from nativescript-videoplayer.

guru1966 avatar guru1966 commented on May 18, 2024

Ok, following steps were done:
$ rm -rf nativescript-videoplayer
$ git clone https://github.com/bradmartin/nativescript-videoplayer.git
$ cd nativescript-videoplayer/demo
$adb uninstall org.nativescript.demo
Success
$ tns build android
$ tns build run

Still same crash as before.

In my main-page.xml I have the following:

...
Should I change the path to xmlns:Video to something else than above inside Demo-app?

from nativescript-videoplayer.

bradmartin avatar bradmartin commented on May 18, 2024

if you aren't modifying the demo then it should work, let me do a test run of it

from nativescript-videoplayer.

bradmartin avatar bradmartin commented on May 18, 2024

oh I think I know, it's likely not transpiling the TS. I manually do that just by habit. I bet that's the issue so if you went and looked in your node_modules you won't see any .js files - shouldn't even have the .ts source files. Let me know if you have nothing in the videoplayer folder in node_modules. there should be a few scripts you can run to prepare the demo and one of them handles the tsc command to transpile the source. After looking at the package.json this plugin I didn't ship with the scripts to prepare the demo and other things, my fault there. Before you run the app, go into the root where the plugin source is and kickoff the compiler via tsc then when you run the app you will have the .js source files in the node_modules where they should be.

from nativescript-videoplayer.

guru1966 avatar guru1966 commented on May 18, 2024

I can only see .ts source files inside node_modules/nativescript-videoplayer/. Seems not compiled to .js source files. You maybe right regarding this. How to resolve that?

skarmavbild 2016-09-29 kl 21 06 53

from nativescript-videoplayer.

bradmartin avatar bradmartin commented on May 18, 2024

run tsc in your terminal - when at the plugin source. So path to nativescript-videoplayer (the root of the cloned repo and run tsc you'll see it process and then you'll have .js files in the root for the plugin, then path to the demo project. Last run or livesync should prepare the plugin which should update the source in the node_modules for the videoplayer and then it will work.

from nativescript-videoplayer.

guru1966 avatar guru1966 commented on May 18, 2024

Yes, running tsc and creating .js files inside nativescript-videoplayer resolved it ! Thank you !

from nativescript-videoplayer.

bradmartin avatar bradmartin commented on May 18, 2024

Yea - I need to add the scripts to the package.json and doc it on the readme. Might do that later 👍

from nativescript-videoplayer.

bradmartin avatar bradmartin commented on May 18, 2024

Copied some scripts over from another project, should fix the issue going forward to not skip the transpile step - didn't test though.

from nativescript-videoplayer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.