Comments (4)
isaacs
commented on August 24, 2024
2
If this is really about donation request banners, they're being phased out in favor of the funding package.json stanza and npm fund command anyway. So I'd like to see another use case, at least, since that one won't matter soon enough.
What happens when the patch doesn't apply?
This feels like one hell of a footgun. I have deep misgivings about supporting it.
from rfcs.
begriffs
commented on August 24, 2024
If this is really about donation request banners, they're being phased
out in favor of the `funding` package.json stanza and `npm fund`
command anyway. So I'd like to see another use case, at least, since
that one won't matter soon enough.
There is no other concrete example I know of. Basically I saw some
Github issues that were full of drama about the banners, and wondered to
myself if there was a technical solution that would allow project
authors to keep the banners if they wanted while letting package
consumers customize it if they cared enough.
The patching idea seemed a simple mechanism that is open-ended enough to
possibly apply to other things.
What happens when the patch doesn't apply?
On failure the patch utility exits with a non-zero code, and npm install
could fail with an error.
This feels like one hell of a footgun. I have deep misgivings about
supporting it.
After thinking about the idea again today, I realized that it may not
fix the original motivation. The banners seem to cause problems when
they appear in deep dependencies, whereas the `--patch` mechanism
applies only when installing a package directly. You could perhaps
specify patches for dependencies, but that feels a lot more complicated
and is probably not worth it.
from rfcs.
isaacs
commented on August 24, 2024
Ok, then I'm gonna close this.
I know that there are registry-side tools that float patches like this, typically for security patches or bugfixes, but it seems like not an ideal fit for the cli.
Thanks for bringing it up, all the same :)
from rfcs.
markcellus
commented on August 24, 2024
FWIW, patch-package would be great for this use case.
from rfcs.
Related Issues (20)
- [RRFC] npm audit fix should consider package source in alert delivery HOT 6
- Sorry, maybe I missed something, I know there's the RFC meetings, but can't find the calendar for them - when is this going to be discussed? Is it better to wait for the meeting or post the questions now?
- [RRFC] Avoid distributing Readme.md when is not needed HOT 15
- [RRFC] Add a Warning Message When Installing Packages into Home Directory HOT 3
- [RRFC] Decompose `bash` completions
- [RRFC] Locally computed integrity values in the lockfile
- [RRFC] Add syntaxs support for [!TIP] blockquotes in markdown files in npmjs.com
- Add Logging for Http Redirects to Package Content
- [RRFC] Structured data for `deprecated` packages about migration paths
- [RRFC] <title>
- [RRFC] allowing to use engines as config variable
- [RRFC] Allow `npm completion` under MSYS2
- [RRFC] <title>
- [RRFC] require authentication only once during one single npm publish using workspaces HOT 5
- [RRFC] Populate `"engines"` field during `npm init` HOT 3
- [RRFC] <title>
- [RRFC] <title>
- Sorry, maybe I missed something, I know there's the RFC meetings, but can't find the calendar for them - when is this going to be discussed? Is it better to wait for the meeting or post the questions now?
- [RRFC] <title>
- [RRFC] Allow packages to declare a schema for what kind of versioning system it uses (Allow use of non-SemVer)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rfcs.