Allow excluding specific file patterns in nested directories about npm-packlist HOT 3 CLOSED

This is a limitation of globs. dist/lib/x.test.js actually does match dist/**/!(*.test.js)/**. First part "dist" matches the first part of the glob. Then the second part ** matches zero folders. The third part !(*.test.js) matches lib. The last part ** matches x.test.js.

I think it should work if you do this, though:

{
  "files": [
    "/dist/",
    "!/dist/**/*.test.js"
  ]
}

The second rule will override the first, and re-ignore those files.

from npm-packlist.

That works for my use case. Thanks!

Could you please clarify why the pattern !dist/**/!(*.test.js)/** is passed to the ignore-walker though? Is it necessary? What I specify in the package.json is dist/**/!(*.test.js), i.e. without the /** at the end.

I'm referring to this block in particular - it takes the pattern p and then converts that to !p and !p/** for the ignore-walker.

from npm-packlist.

Because at that point it does not know if it's a directory or a file.

This behavior is overly aggressive in what it includes, though, and leads to problems. For example, "files": ["lib"] will include lib/.DS_Store, which you never want.

That'll be fixed in v2.

from npm-packlist.