Loading node-semver via browserify throws errors in closure compiler verbose mode about node-semver HOT 9 CLOSED

Why is clojure compiler complaining about these things?

Using the typeof operator on a undefined reference is safe. Setting a variable without var defines it as a global, which is also valid JavaScript.

This is a bug in clojure.

from node-semver.

Also, if you're using browserify, then it's wrong -- exports and module WILL be defined when this script is run.

from node-semver.

Thanks for your quick reply @isaacs.

I'm sorry I took a shortcut and the output above was inaccurate:

Also, if you're using browserify, then it's wrong -- exports and module WILL be defined when this script is run.

You're right - those two will be defined - but semver is not.

The error thrown during closure compiling the browserified script was actually just ERROR - variable semver is undeclared semver = {}.

The previous output was got using Google Closure Compiler on the whole browser bundle (which in retrospect was not a fair test). Apologies for the confusion.

from node-semver.

Well... look at the code. It's only going to assign to the semver global if module and exports are undefined. And if they are undefined, then it's not "leaking" a global, it's intentionally setting a very specific global.

So, this is still a case of clojure being either overly zealous or misconfigured.

from node-semver.

Sorry, I misspoke, it'll set semver = {} if both exports and define are unset. It sniffs module.exports to determine whether it's in a Node-like system or simply a CommonJS-like system.

from node-semver.

Ok I think this is just a case of different opinions of coding style. Thanks for your time in going through this with me and explaining it in detail. I have a workaround - and I will discuss with my colleagues about whether we should reduce the enthusiasm of our current Google Closure Compiler settings. Thank you again.

from node-semver.

Oh, I just realized, if it's getting tripped up by the code style of putting semver = {} on a new line, I'd be happy to accept a patch to shuffle things around so that clojure will be happy. But it should be posted as a bug upstream.

from node-semver.

I will investigate this and get back to you.

Thanks for your advice.

from node-semver.

@matthew-andrews Did you ever find a work-around please?

from node-semver.