Giter Club home page Giter Club logo

Comments (4)

nevo-david avatar nevo-david commented on September 27, 2024 1

from website.

diwash007 avatar diwash007 commented on September 27, 2024

I see it is only on profiles of new contributors may be due to a background process to generate the image.
Should we instead show the GitHub avatar like that of og:image or what should we do here? @nevo-david

from website.

diwash007 avatar diwash007 commented on September 27, 2024

But the generated image is better .. That means we should show GitHub avatar until the image has been generated .. that ll be better

from website.

andrewgolovanov avatar andrewgolovanov commented on September 27, 2024

That's a great catch! 👏 And it's really that unpleasant thing that needs to be fixed! But I'm not sure whether avatar or siteImage should be shown instead of image, first of all these images are not of the right size, secondly it will lead to new open issue - hello guys, why I've some strange image when I want to share? - this will confuse users, and it also does not give an understanding of whether there will ever be a correct image like other users or it is a bug - which leads to the same new open issue for fixing

I see several simple solutions at the moment:

  1. Checking if the image is available to share - if the image is not yet generated, we hide the user page on the page until the image is ready (I don't see anything wrong with this, to me this is a normal process - preparing data takes some time to display correctly later)
  2. Add a stub for the modal window in the form - we're already working on your unique image that you can share soon, please come back a bit later to get it, thanks!
  3. Hide the share buttons until we have access to the image

from website.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.