Giter Club home page Giter Club logo

Comments (7)

xrigau avatar xrigau commented on July 22, 2024

where does that recommended time come from?

from sqlite-provider.

blundell avatar blundell commented on July 22, 2024

I have no idea what reference they have for that. Isn't it the time per frame before jank?

from sqlite-provider.

xrigau avatar xrigau commented on July 22, 2024

could be the time ignoring GC
¯_(ツ)_/¯

from sqlite-provider.

blundell avatar blundell commented on July 22, 2024

Using TimingLogger we determined this is the line that causes the slow down for this

String[] sqls = assets.list(migrationsPath); (Migrations:121)

The issue only arises when you have a certain number of migration files (device dependent) 10_ migration files in our case.

Considering alternative solutions, we can't speed up assets.list as it is a framework class.
We could move all assets to res/xml as these would be compiled and the name references would be available instantly, however this is a breaking api change and not being considered right now.
We could also allow the library user to pass the number of the file wanting to be used so that this lookup is not needed. However this might not be possible due to the creation time and also it defeats half the point of having the migration file (vs the normal version number declaration).

So right now this is a WILL NOT FIX.

from sqlite-provider.

blundell avatar blundell commented on July 22, 2024

[[selfie-0 uploading...]]

from sqlite-provider.

ouchadam avatar ouchadam commented on July 22, 2024

is the beef that this is working on the main thread?

from sqlite-provider.

blundell avatar blundell commented on July 22, 2024

yeah, don't think it can be backgrounded ... it's instantiating the content provider

from sqlite-provider.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.