Change to NPPM_RELOADFILE in development build affects plugins about notepad-plus-plus HOT 6 CLOSED

The call to _pluginsManager.relayNppMessages() at the end of Notepad_plus::process is unreachable because the NPPM_RELOADFILE callback returns immediately, whereas before there was only a break statement in there.

from notepad-plus-plus.

For documentation reasons/tracking information: The result value has been adapted to return TRUE on success and FALSE on failure.

See commit:
060396c

from notepad-plus-plus.

In short, NPPM_RELOADFILE should return TRUE on success and return FALSE on failure.
As the "Notepad_plus_msgs.h" says:

#define NPPM_RELOADFILE (NPPMSG + 36)
	//BOOL NPPM_RELOADFILE(BOOL withAlert, TCHAR *filePathName2Reload)

from notepad-plus-plus.

To be clear, we think this is a breaking change in Notepad++, not the plugin.

from notepad-plus-plus.

@vinsworldcom

To be clear, we think this is a breaking change in Notepad++, not the plugin.

What's broken is the (until now) implicit assumption that NPPM_RELOADFILE would be forwarded to plugins via PluginsManager::relayNppMessages. Despite the documentation, the API would have always returned FALSE before (instead of always TRUE as now); the default value of the local result variable was never updated anywhere along the old code path. Plugins can send NPPM_RELOADFILE by themselves as they always could before; they just have to reverse their expectation about the return value.

Having said that, it does not look like a deliberate API change was intended here. In a function that's so overlong the compiler warns about how much local data is pushed to the stack ¹, it's easy to forget there's a call site at the bottom.

from notepad-plus-plus.

@vinsworldcom
Could you check the PR #14708 please?

from notepad-plus-plus.