Comments (4)
Hi, my previous assessment that this would work seem to be wrong..
The problem with pub/sub is that hiredis keeps its callback-info to be able to reuse this for all messages, while redis-cluster currently dont. hiredis-cluster frees its cluster_async_data
after each called callback.
One possible fast-fix until this is handled correctly in hiredis-cluster could be to use the hiredis api directly in your connectCallback()
. Here you have the redisAsyncContext for the specific node already and instead of iterating all nodes again you could use this redisAsyncContext as in the hiredis tests.
The callback would have a different signature but maybe thats ok?
We also need to findout how to handle this correctly in hiredis-cluster.
from hiredis-cluster.
Thank you. We will try out your suggestion.
With regards to the issue with the PSUBSCRIBE response we mentioned, the null
there was because we were reading reply->element[j]->str
in eventCb()
.
Changing that to reply->element[j]->integer
has fixed that problem.
from hiredis-cluster.
Some notes of options how to solve this a near future:
-
Option 1: Add information in hiredis
redisCallback
to inform user if the redisCallback-object with the privdata reference will be deleted or kept by hiredis (kept when pubsub).
This will be used to know if hiredis-clusterscluster_async_data
object should be deleted or not. -
Option 2: Like hiredis, check sent commands to find "*SUBSCRIBE" and set a flag in the created
cluster_async_data
that this callback is used for pubsub. With this knowledge we know whencluster_async_data
should be deleted or not. When flagged to be a subscribe callback we should not delete thecluster_async_data
since it's a published message, and the callback is reused.
Drawbacks I can think of
- In both options above we dont know when its ok to delete
cluster_async_data
after anUNSUBSCRIBE
has been sent. hiredis dont call the user callback when response to SUBSCRIBE/UNSUNSCRIBE comes..
from hiredis-cluster.
See #27
from hiredis-cluster.
Related Issues (20)
- Does hiredis-cluster support SSUBSCRIBE? HOT 2
- Compilation error LIBEVENT_INCLUDES-NOTFOUND HOT 3
- MOVED ERROR in pipeline-API when increasing shards in existing redis cluster HOT 10
- Target "hiredis::hiredis" because target "hiredis" is not a library HOT 1
- During cmake, Checking for module 'glib-2.0' No package 'glib-2.0' found HOT 2
- nodeNext strange behaviour after master failover. HOT 9
- With redisClusterAsyncCommandArgvToNode api, client not discovering new nodes on redis master node disconnect HOT 4
- Update the slotmap after send errors/timeouts in the sync API HOT 1
- hircluster.c:218:9: 错误: HOT 4
- Failed to find keys of command XREADGROUP HOT 2
- Recovery in case of discovered slots from redis cluster is partial HOT 2
- is redisClusterAppendCommand, redisClusterGetReply thread Safe? HOT 1
- SIGSEGV in clusterNodesReplyCallback while calling redisClusterAsyncFree HOT 3
- The connection always been close after every redisClusterCommandArgv HOT 1
- Unable to execute commands without keys (FLUSHALL, PING, INFO) HOT 2
- redisClusterAsyncDisconnect behaviour when a redisAsyncContext object has seen some error HOT 1
- symbol lookup error: /usr/local/lib/libhiredis_cluster.so.0.13: undefined symbol: hiredisAllocFns HOT 4
- Does hiredis-cluster support SCAN HOT 1
- Event loop occasionally hangs after redisClusterAsyncDisconnect under high connection error conditions HOT 2
- Crash while performing redisClusterAsyncFree() HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hiredis-cluster.