Comments (2)
After first having run a lots of test with node restarts I could only find a segfault issue that is to be fixed with #107, but the assert() described above was never hit.
In my tests redisClusterAsyncCommand
is either called by a timer event or via an event_base_once.
Normally a command callback is called by the underlaying hiredis and when the connection is disconnected hiredis will reset the async context pointer in a node object, i.e the assert should not be reached/triggered.
But, I think I managed to reproduce the issue when calling redisClusterAsyncCommand
from a command callback, i.e. when a given callback is called after a command has been sent. This callback gives a NULL reply when a connection is broken, but if it also attempts to send a new command before the callback has finished the node object still has an async context with errors.
Is this similar to your setup? I.e do you use libevent and send commands from a command callback?
from hiredis-cluster.
Thank you.
We are invoking redisClusterAsyncCommand()
calls both from the application, and also from hiredis callbacks.
But we have also added a guard -- we return immediately without processing any Redis callbacks that get called after the disconnect callback indicating that the connection has broken. So the assert must be getting triggered from redisClusterAsyncCommand()
called by the application.
from hiredis-cluster.
Related Issues (20)
- Does hiredis-cluster support SSUBSCRIBE? HOT 2
- Compilation error LIBEVENT_INCLUDES-NOTFOUND HOT 3
- MOVED ERROR in pipeline-API when increasing shards in existing redis cluster HOT 10
- Target "hiredis::hiredis" because target "hiredis" is not a library HOT 1
- During cmake, Checking for module 'glib-2.0' No package 'glib-2.0' found HOT 2
- nodeNext strange behaviour after master failover. HOT 9
- With redisClusterAsyncCommandArgvToNode api, client not discovering new nodes on redis master node disconnect HOT 4
- Update the slotmap after send errors/timeouts in the sync API HOT 1
- hircluster.c:218:9: 错误: HOT 4
- Failed to find keys of command XREADGROUP HOT 2
- Recovery in case of discovered slots from redis cluster is partial HOT 2
- is redisClusterAppendCommand, redisClusterGetReply thread Safe? HOT 1
- SIGSEGV in clusterNodesReplyCallback while calling redisClusterAsyncFree HOT 3
- The connection always been close after every redisClusterCommandArgv HOT 1
- Unable to execute commands without keys (FLUSHALL, PING, INFO) HOT 2
- redisClusterAsyncDisconnect behaviour when a redisAsyncContext object has seen some error HOT 1
- symbol lookup error: /usr/local/lib/libhiredis_cluster.so.0.13: undefined symbol: hiredisAllocFns HOT 4
- Does hiredis-cluster support SCAN HOT 1
- Event loop occasionally hangs after redisClusterAsyncDisconnect under high connection error conditions HOT 2
- Crash while performing redisClusterAsyncFree() HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hiredis-cluster.