Giter Club home page Giter Club logo

Comments (3)

noib3 avatar noib3 commented on May 28, 2024 1

Hey thanks for the feedback. I don't think it's related to serde, I can replicate the issue simply with

use nvim_oxi::{self as oxi, Dictionary, Function, Object, Result};

// Passing a table here causes a segfault.
fn setup(_: Object) -> Result<()> {
    Ok(())
}

#[oxi::module]
fn foobar() -> Result<Dictionary> {
    Ok(Dictionary::from_iter([("setup", Function::from_fn(setup))]))
}

I have an idea about what could be causing this but I'll look into it.

from nvim-oxi.

noib3 avatar noib3 commented on May 28, 2024 1

This should be fixed in f08099d. There is one gotcha however: an empty table will be deserialized as an array instead of a dictionary:

require("foobar").setup({}) -- <- gives error

a possible workaround is to implement Deserialize for Config by hand, implementing the Visitor::visit_seq method on your visitor to check if the sequence is empty.

from nvim-oxi.

epwalsh avatar epwalsh commented on May 28, 2024

Thanks @noib3!

from nvim-oxi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.