Giter Club home page Giter Club logo

Comments (4)

SamStephens avatar SamStephens commented on May 23, 2024 1

Oh okay, that's embarrassing, apologies for the mistake. I was confused here because

curl -fsSL https://deb.nodesource.com/setup_20.x | bash -

Has an exit code of 0, hence Dockerfile execution continues, whereas

curl -fsSL https://deb.nodesource.com/setup_20.x

Has an exit code of 127.

I wonder if there's an alternative way to formulate a command to download and run https://deb.nodesource.com/setup_20.x that will fail if curl is not present?

Especially as this behavior will mask other errors, such as transient 5xx failures, meaning curl -fsSL https://deb.nodesource.com/setup_20.x | bash - isn't really safe in an automated context.

from distributions.

SamStephens avatar SamStephens commented on May 23, 2024 1

@riosje unfortunately the formulation with the && is subject to the same issue.

As I said above, curl -fsSL https://deb.nodesource.com/setup_20.x | bash - has an exit code of 0 when curl is not available. I'm not that deep on shell internals, but it appears the exit code is the zero from the bash that is the pipe destination, not the curl command pipe source with it's 127 exit code.

This is why I formulated things as I did. From a Dockerfile perspective

RUN curl -fsSL https://deb.nodesource.com/setup_20.x | bash -
RUN apt-get install -y nodejs

is functionally equivalent to

RUN curl -fsSL https://deb.nodesource.com/setup_20.x | bash - && apt-get install -y nodejs

with execution being halted before apt-get runs if curl -fsSL https://deb.nodesource.com/setup_20.x | bash - has a non-zero exit code.

You can see this empirically with the Dockerfile

FROM python:3.11-slim-bookworm

RUN apt-get update --fix-missing && apt-get upgrade -y && apt-get dist-upgrade -y

RUN curl -fsSL https://deb.nodesource.com/setup_20.x | bash - && apt-get install -y nodejs
RUN node -v
RUN npm -v

Which is subject to the same issue as my original reproduction.

from distributions.

riosje avatar riosje commented on May 23, 2024

Hi @SamStephens.
I tried you Dockerfile but it fails because at first curl is not installed, for that reason
Try installing curl at first :

FROM python:3.11-slim-bookworm

RUN apt-get update -y && apt-get install curl -y
RUN curl -fsSL https://deb.nodesource.com/setup_20.x | bash -
RUN apt-get install -y nodejs
RUN node -v
RUN npm -v

installing

from distributions.

riosje avatar riosje commented on May 23, 2024

Hi @SamStephens that's why we have the following in the README.

curl -fsSL https://deb.nodesource.com/setup_20.x | bash - && \
apt-get install -y nodejs

The apt-get install will not be executed unless the curl returns an exit code 0.
That's what the && operator does.

from distributions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.