Comments (7)
I haven't looked at the code for the bot, but theoretically could we just replace the PR author setup with the first commit author?
I'm happy to take a look at it, but I'm not a CODEOWNER, just a triage member
@nodejs/github-bot
from node.
I think that's a limitation of the GitHub API – the alternatives/workaround are:
- land the PR with
commit-queue-rebase
Add this label to allow the Commit Queue to land a PR in several commits. (i.e. no purple merge) - land the PR manually
- add the original author as a co-author
I've been trying to do the latter when I notice the commit author is not the same person that sent the PR. I guess we could implement a check to refuse to land a PR when the author will be wrong.
from node.
I guess we could implement a check to refuse to land a PR when the author will be wrong.
That seems (IMO) a good solution, but I'm far from the person who would be affected by any of this
from node.
This changed recently, before when you added the "commit-queue-squash" it would squash on the first commit and keep the author of the first commit as the author of the landed commit.
Now the author of the pr becomes the author of the landed commit regardless if the first commit is theirs
from node.
I made a little experiment using the GH UI: targos#18, targos@adf6657
Squash and merge indeed changes the author (it doesn't let you keep it, you can only select the email address you want to be associated with the commit).
It adds a Co-authored-by:
field to the commit message, though.
from node.
This changed recently, before when you added the "commit-queue-squash" it would squash on the first commit and keep the author of the first commit as the author of the landed commit.
I think you're misremembering, AFAIK it's always been the case that GH uses the "PR opener" as commit author – and we're using the GH API since #40666.
from node.
This changed recently, before when you added the "commit-queue-squash" it would squash on the first commit and keep the author of the first commit as the author of the landed commit.
I think you're misremembering, AFAIK it's always been the case that GH uses the "PR opener" as commit author – and we're using the GH API since #40666.
I remember #45597 maybe it was landed with git node land
from node.
Related Issues (20)
- Issue with loadEnvFile in ESM HOT 1
- Support load balancing HTTP requests across worker threads HOT 10
- WASM crashes on Node v22.2.0 if it reaches the new Buffer() deprecation warning HOT 2
- Node incorrectly responds 400 to invalid data sent after requests with `Connection: close` HOT 7
- watch with test not picking up new test files HOT 8
- T
- 'ERR_INTERNAL_ASSERTION' Using DOTENV plugin in Angular: 17.3.0and NodeJs v20.13.1
- ESM mistaken for CJS despite --experimental-detect-module HOT 7
- intl.datetimeformat comma removed after version 20.11.1 HOT 8
- test-buffer-failed-alloc-typed-arrays test failures HOT 4
- wasi fast calls causes segfault on x86_64-linux when running a wasm32-wasi module
- Accept `Blob`s anywhere where a `Buffer` is currently accepted for writing HOT 1
- /usr/local/lib/nodejs
- Node.js
- parseArgs with type: "boolean" and default: true does not allow a false value HOT 4
- yarn install dependency package throw error"error Error: incorrect data check at Zlib.zlibOnError [as onerror] (node:zlib:189:17)" HOT 2
- ESM loader hooks in Workers no longer working since Node.js 22.2 HOT 7
- `fs.watch` doesn't listen changes of file containing JSON stringified if changes happen too quickly (behavior different with non JSON) HOT 1
- Node 20.13 --watch option breaks loader / preload of modules HOT 3
- `node:test` custom reporters get `test:stdout` and `test:stderr` events before `test:dequeue` HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node.