Abort with fatal error when error-handling fails about node-addon-api HOT 3 CLOSED

We've been down this road before. How can we abort portably without replicating node::FatalError()?

from node-addon-api.

Previous discussion was about being able to call node::FatalError() (or equivalent) in the implementation of some functions in node_api.cc. But that wasn't really necessary since they could return error codes instead.

In this case, if N-API functions fail when handling an error in the C++ wrapper, then the options are:

• Silently ignore the error on release builds (assert on debug builds)
• Throw some other kind of C++ exception (not expected by the caller, and if N-API isn't working then the caller can't do anything reasonable to handle it)
• Abort in some other way such as std::abort() (which wouldn't provide any diagnostic information).

The suggestion here is to expose a fatal error function directly as napi_fatal_error(), so that native addons (and the C++ wrapper) can call it. Now, we'll still have the problem that node::FatalError() doesn't exist on older versions of Node. So, for those versions at least, we may have to replicate it. But I think that's OK, if the new API is justified.

Now, all this may be a waste of effort since napi_get_last_error_info() and napi_create_error() are unlikely to fail for any reason other than invalid args. That's why I originally thought just assertions would be sufficient, since any error is more likely to be just a coding mistake during development.

from node-addon-api.

This was done in #70

from node-addon-api.