.defines instead of isNodeApiBuiltin about node-addon-api HOT 12 CLOSED

Also, all the other node-addon-api exports can be added unconditionally to either the "include_dirs" or "dependencies" of a dependent target, because the conditionality is encapsulated in index.js.

from node-addon-api.

I guess it doesn't really cost that much to keep .isNodeApiBuiltin so we export something that can be used as a condition statement for unforeseen use cases, but we should definitely have the .defines in addition.

from node-addon-api.

The .isNodeApiBuiltin export was meant to be exposed as a runtime flag in case anybody wanted to write code to check that. But it's not used anywhere today, and there should be no need to use it at build time.

Did you follow the instructions in the README? You shouldn't need to define EXTERNAL_NAPI anywhere in your module's node.gyp. That is taken care of by these two lines to be added to your node.gyp:

  'include_dirs': ["<!(node -p \"require('node-addon-api').include\")"],
  'dependencies': ["<!(node -p \"require('node-addon-api').gyp\")"],

Then when you #include "napi.h" that should get src/napi.h that has #define EXTERNAL_NAPI at the top.

from node-addon-api.

I don't use the C++ API.

from node-addon-api.

https://github.com/gabrielschulhof/iotivity-node/blob/node-addon-api/binding.gyp#L221-L232

from node-addon-api.

OK, I guess I can include napi.h directly, because I'm doing C++ anyway.

from node-addon-api.

I can't use napi.h because that requires exception handling to be enabled, which, for the plain C API I don't need.

from node-addon-api.

Hmm... using only the C APIs via this package wasn't a scenario I considered.

from node-addon-api.

Well, adding .defines and a mention in the README.md should cover plain C.

from node-addon-api.

Yes that will work. I had wanted to minimize the amount of stuff you have to add to your .gyp file. But one more line won't hurt.

from node-addon-api.

Although perhaps you could do the path juggling as you do now, but instead of including napi.h after defining EXTERNAL_NAPI, you include node_api.h.

from node-addon-api.

... and then, when napi.h includes node_api.h, it will receive it from the appropriate directory.

from node-addon-api.