Comments (2)
kkoopa
commented on August 22, 2024
My first concern is that it could cause confusion with regard to the other similarly named String-related stuff, which take a v8::String as input. 'NanString' is 2 characters shorter than 'String::New', but adding a qualifier to reduce confusion, e.g. 'NanToString' gives no benefit. Then again, having one half, but not the other is arguably a bit weird.
In short: Currently, I don't see how the benefits would outweigh the drawbacks.
from nan.
Sannis
commented on August 22, 2024
Ok, lets keep it as is.
from nan.
Related Issues (20)
- Copy *.node addon compiled file from compiling machine to another machine (client) same system
- How to convert an int64 to NodeJs BigInt. HOT 1
- Cross Compile for ARMv5 HOT 2
- Switching to NAN_MODULE_WORKER_ENABLED broke my native node module HOT 1
- strings-test.js fails on s390x
- `Nan::SetAccessor()` deprecation warning with V8 10.1 and nan 2.15.0 HOT 9
- nan_callbacks.h:55:23: error: ‘AccessorSignature’ is not a member of ‘v8’ HOT 16
- NAN_MODULE_INIT cast warning on Node v16 HOT 19
- Nan::SetProperty (const char * version of Nan::Set to match Nan::SetMethod) HOT 4
- 'IdleNotificationDeadline' is deprecated: Use MemoryPressureNotification() HOT 3
- v8 Fast API with NAN.h
- Use GitHub Actions and delete Travis / AppVeyor configuration HOT 2
- Native node module crashes due to ObjectWrap::Unwrap<> returning a different pointer than what was passed to ObjectWrap::Wrap<>
- can this node-gyp warning be dealt with? HOT 3
- Nan is enforcing wrong ~1GB kMaxLength for Nan::NewBuffer, should be 4GB
- v8 Fast Api with NAN
- Breaking code in ViteX Exchange HOT 2
- Can't compile simple program on Windows with Node.js 22 HOT 1
- Error when building NAN modules targeting Electron 31.0.0-beta.8 ('CopyablePersistentTraits': is not a member of 'v8') HOT 3
- Nan with Node 18 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nan.