Comments (8)
@trevnorris would you mind if I added you as a collaborator to this repo? I'd love to have your contributions since you know the node internals much better than I.
from nan.
Sure.
Ironically I started to throw together some convenience stuff and threw it
into a package called njsutil on npm. If you want, take a look an let me
know if there's anything you'd like me to port over.
from nan.
OK, I've added you. Since this is a download-from-github project, we'd better do everything off-master until stuff is ready for "release". I have an 0.2.0 branch on the go already. pull-request for additions and major fixes would be appreciated so there can be discussion too.
Will have a look at njsutil. Thanks!
from nan.
Any updates on this? I just started reimplementing node::StringBytes, but it seems necessary to add most of it, which create a fair amount of clutter -- assuming we want to stick to a single file. I assume the same issue will arise when backporting node::Cached.
from nan.
I'd prefer a single header file if possible, but if we need to add a compiled unit then it could be added as an optional extra perhaps? With some instructions on what to put in your .gyp file, or just export a full .gyp with instructions on how to depend on it in your own .gyp. But if possible, lets try and cram it all in to a header.
if it's a matter of just making the header file too big.. well, I'm not sure I'm too concerned about that, as long as we can try and keep it relatively well organised. It'll compact nicely enough in the .tgz published packages.
from nan.
Yes, sounds reasonable. Might want to wrap parts in #ifdefs if they may or may not be wanted. On closer inspection of this particular issue, it seems like I can get by with a lot less code. I might have a semi-working draft done in an hour or two.
from nan.
970421b contains a work in progress. It still requires some fixing and I am not sure on e.g. when zero terminators need to be added, e.g. should buffers get an extra terminating zero?
from nan.
I think this one is finally sorted out. Closing.
from nan.
Related Issues (20)
- Copy *.node addon compiled file from compiling machine to another machine (client) same system
- How to convert an int64 to NodeJs BigInt. HOT 1
- Cross Compile for ARMv5 HOT 2
- Switching to NAN_MODULE_WORKER_ENABLED broke my native node module HOT 1
- strings-test.js fails on s390x
- `Nan::SetAccessor()` deprecation warning with V8 10.1 and nan 2.15.0 HOT 9
- nan_callbacks.h:55:23: error: ‘AccessorSignature’ is not a member of ‘v8’ HOT 16
- NAN_MODULE_INIT cast warning on Node v16 HOT 19
- Nan::SetProperty (const char * version of Nan::Set to match Nan::SetMethod) HOT 4
- 'IdleNotificationDeadline' is deprecated: Use MemoryPressureNotification() HOT 3
- v8 Fast API with NAN.h
- Use GitHub Actions and delete Travis / AppVeyor configuration HOT 2
- Native node module crashes due to ObjectWrap::Unwrap<> returning a different pointer than what was passed to ObjectWrap::Wrap<>
- can this node-gyp warning be dealt with? HOT 3
- Nan is enforcing wrong ~1GB kMaxLength for Nan::NewBuffer, should be 4GB
- v8 Fast Api with NAN
- Breaking code in ViteX Exchange HOT 2
- Can't compile simple program on Windows with Node.js 22 HOT 1
- Error when building NAN modules targeting Electron 31.0.0-beta.8 ('CopyablePersistentTraits': is not a member of 'v8') HOT 3
- Nan with Node 18 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nan.