../src/node_jsvmapi.cc:192:3: error: ‘interface’ does not name a type about abi-stable-node HOT 7 CLOSED

@boingoing ^

from abi-stable-node.

This line is:

interface CallbackWrapper {
...

Does the 'interface' keyword not exist in GCC? Is 'interface' an ISO standard keyword? I'm actually not sure. Looks like it might be an MSVC-specific #define. Maybe we should replace this with class or struct for compliance sake?

from abi-stable-node.

I think so. It certainly doesn't build out of the box.

from abi-stable-node.

@jasongin
Seems like replacing 'interface' with 'struct' should solve the issue. Is there a reason to use 'interface'? I'm actually not super familiar with it.

from abi-stable-node.

There is another build issue on gcc, too, so I started a PR. #70

from abi-stable-node.

Yes, interface is just an alias for struct, supported by MSVC but not GCC. I had a habit of using interface from Windows programming, since it explicitly declares the intent for the struct to only have abstract methods. But it's certainly not required.

from abi-stable-node.

Fixed by 5ae919a

from abi-stable-node.