Comments (3)
Please, write a more essential test, what will be broken in real life.
from babelfish.
getCompiledData() MUST have locale param (the first one).
from babelfish.
Please, write a more essential test, what will be broken in real life.
Something test-like in first-message already. I'd like to help in other way, but currently have no time to dig into internals, sorry. Maybe later, doesn't seem so critical anyway.
Nothing will break, just feels odd. As far as I can see, such call results in compiling phrases for fallbackLocale
and writing result to _storage['undefined']
returned by getLocaleStorage(this, undefined)
. Now we have two disctinct objects with same data (_storage[fallbackLocale]
and storage['undefined']
, latter just lives there and probably never going to be used / GC'ed), memory wasted.
getCompiledData() MUST have locale param (the first one).
Throw then? (It's done in addPhrase
and other places, so I guess there is no policy against exceptions.)
from babelfish.
Related Issues (20)
- Improve compatibility with old browser & es5-shims HOT 2
- Support for complex types HOT 30
- parser rewrite HOT 1
- Babelfish Perl module HOT 2
- Array.prototype.indexOf doesn't exist in IE<9 HOT 2
- Support for pluralization-based keys HOT 6
- syntax extention: formats HOT 1
- coerce simple types for simple calls HOT 1
- update CLDR rules to latest HOT 1
- Lazy compile HOT 1
- Move pluralizer to separate package with autogenerated src HOT 2
- YAML HOT 2
- angular babelfish HOT 2
- Question: Default fallback for country variant HOT 4
- NL breaks compilation when phase contains macros
- Automatize browserification and runtime generations
- Relax plurals syntax - find variable automatically HOT 1
- .getTranslation HOT 4
- Zero-count in plurals HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from babelfish.