Giter Club home page Giter Club logo

Comments (6)

DaveEslinger avatar DaveEslinger commented on September 24, 2024 1

Sure, A vs B is ok, but then the equation becomes 100 * (A - B)/B. That way, if there if A DECREASED, the percentage is negative; if A increased, the percentage is positive.

I would like to stick with that usage: negative means a decrease, that is what we've trained users to expect. Think of it as the change from some original state to a new state. The percent change would be: 100 * (New - Original) / Original, and our naming convention would be New vs Original.

In the current code, I just think the denominator is wrong; it should be B.

from qnspect.

NSPECT avatar NSPECT commented on September 24, 2024

Good catch, the formula should be 100 * (B - A)/ A which is the change from A to B:

The results using your numbers would then be: [[-20%, 100%]], a decrease to 20% for the first element, and a increase of 100% for the second.

from qnspect.

NSPECT avatar NSPECT commented on September 24, 2024

Oops, [[-80%, 100%]]. math is hard.

from qnspect.

ar-siddiqui avatar ar-siddiqui commented on September 24, 2024

Since, our Results Group name is A vs B I think what we have might already be correct.
A is 80% greater than B, A is 100% smaller than B.

vs

If we change the formula it will be
B is 80% less than A and B is 100% more than A

What do you think will be better considering our group name A vs B? I think it is just a way of interpretation but thinking about it more I like the first one.

from qnspect.

ar-siddiqui avatar ar-siddiqui commented on September 24, 2024

Ok 100 * (A - B)/B makes much more sense. Glad we caught this. Is this the same what OpenNSPECT had or is it different?

from qnspect.

DaveEslinger avatar DaveEslinger commented on September 24, 2024

It should be the same.

from qnspect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.