Consistent maximum length of filenames? about fms HOT 4 CLOSED

We discussed this issue yesterday and we are looking at some sort of parameter integer value of 1024. We are looking at where to put it also because it needs to be fairly low-level. Is 1024 sufficiently long enough?

We have a release scheduled for a few weeks (mid august), so hopefully there is a relatively quick turn around.

from fms.

I believe in MAPL we still have a few places using ESMF_MAXPATHLEN so 1024 might be good.

More recent work in MAPL has moved us to use allocatable strings:

character(len=:), allocatable

which sort of make all this less necessary anymore. But that would a pretty big rewrite. 😄 (I'm also not sure if that last nvfortran caveat is necessary anymore...I should test that.)

from fms.

The code I saw was this in mpp_util.inc:

    character(len=128) :: filename
...
    filename='input_'//trim(pelist_name)//'.nml'
    inquire(FILE=filename, EXIST=file_exist)
    if (.not. file_exist ) then
       if (present(alt_input_nml_path)) then
          filename = alt_input_nml_path
       else
          filename = 'input.nml'
       end if
    endif

where even if alt_input_nml_path is passed in and is 500 chars long, it'll be truncated to 128 by filename.

from fms.

After testing with the new FMS/2023.04 version in JEDI after recent updates, this is still an issue. We would really appreciate a solution as this is impacting our CI tests.

I guess the latest update regarding this was the following?

From the 2023.02 Changelog:

• MPP: Added workaround for GCC 12 issues causing errors with string lengths in fms2_io

from fms.