Comments (5)
You may keep using _ml_set_feature_check for unit-test. You are not doing integration test; thus, you are not supposed to test other operating system (Tizen) features with your unit tests.
_ml_set_feature_check is not a workaround for unit-test, although you are NOT supposed to use it in integration test or tests in an actual target devices.
Comments on the "Long term solutions"
1: no. you don't need to do so.
2: yes, for Tizen, you need to do so for integration tests (there are such tests in dashboard.tizen.org, conducted when you do SR). But, keep in mind that this is a different and independent test set and you should keep the current "conventional" unit tests.
3: no. you are going to test tests, not the core implementation.
4: no. you are over-engineering. turning on/off feature checks is sufficient.
If you want to test feature-checks correctly, you need to add integration test cases (look at "ITC" of Tizen)
from api.
cibot: Thank you for posting issue #110. The person in charge will reply soon.
from api.
Pulling comment here @jaeyun-jung
nnstreamer/nntrainer#1712 (comment)
Need discussion later.
To run the unittests on gbs-build, we should block tizen-feature for ML API. Internally ml-api (api repository, nnstreamer only now) disables feature state while running unittests.
If nntrainer uses ml-common APIs (tensors-info and tensors-data), unittests in nntrainer always report failure because common ML API cannot check the feature state on gbs-build.
from api.
Cool, thanks for the comment!
As per comment, I guess nnstreamer/nntrainer#1715 is sufficient to close this issue :)
You may keep using _ml_set_feature_check for unit-test.
@jaeyun-jung could you once review nnstreamer/nntrainer#1715 for the completeness?
Thank you!
from api.
Resolved with nnstreamer/nntrainer#1715 :)
from api.
Related Issues (10)
- Create a mirroring repo at tizen.org
- [Android] Add android build script and setup CI HOT 1
- DBus Interface HOT 1
- Invite SNAP developers and let them migrate headers
- [android][bug] Android singleshot test fail HOT 2
- [ml-service] Remote launch/request HOT 2
- Test failure of ML-service-agent HOT 2
- Capi-ml-common is depending on capi-base-common HOT 1
- Migrate ML inference API from nnstreamer HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from api.