Comments (8)
A quick glance of the changes makes me believe the plugin should still run on webpack v4 (although i didn't test it yet) but webpack will probably emit deprecation warnings.
Must likely we need to change last-call-webpack-plugin
s implementation to completely conform with v4 plugin system changes (optimize-css-assets-webpack-plugin
uses last-call-webpack-plugin
dependency to interact with webpack bundle pipeline).
Lately i haven't had much time to solve issues but i intend to work on them in the next weekend.
We are open to PRs if you wish to contribute :)
For this issue the changes should start on last-call-webpack-plugin
repo.
last-call-webpack-plugin
allows to process webpack assets, just give it a RegEx (to filter what assets to process) and a process function.
last-call-webpack-plugin
should be changed to conform with webpack v4 plugin system changes.
Thanks for the support :)
from optimize-css-assets-webpack-plugin.
I just released [email protected]
supporting the new webpack v4 plugin API.
PS: I did some small tests on [email protected]
and besides the deprecation warning the plugin seemed to work correctly with webpack v4.
from optimize-css-assets-webpack-plugin.
For tests see issue #31
I believe some base work was started.
from optimize-css-assets-webpack-plugin.
Hey @thescientist13 we've started work on testing this plugin here and are iterating on that as time permits to get it into a fully PRable state.
We'd welcome contributions (see the unchecked items) but it might make more sense to start with the last-call-webpack-plugin
as @NMFR suggested. Be in touch if you do start working on tests (or see an issue in tests with the v4 migration) so we don't end up duplicating work. Thanks!
from optimize-css-assets-webpack-plugin.
I just tested and all is looking good in my project! thanks for the great work on this plugin! 🙏 🎉
from optimize-css-assets-webpack-plugin.
Great, thanks for the feedback @NMFR ! Will try and take a look this week 👍
Oh, I've been looking into helping out another plugin too (anthonygore/html-critical-webpack-plugin#10) with upgrading to v4, and have started off by writing some unit tests for them (they didn't have any) first, before doing the upgrade. Would you be opposed to that here as a separate, preliminary PR? I don't mind taking that on with a little help if need be.
from optimize-css-assets-webpack-plugin.
thanks @NMFR will do!
from optimize-css-assets-webpack-plugin.
Thanks @NMFR !
from optimize-css-assets-webpack-plugin.
Related Issues (20)
- TypeError: value.split is not a function
- used with webpack5 HOT 2
- Deprecation Warning HOT 3
- cssnano@5 support HOT 6
- webpack v5 support HOT 15
- Security vulnerability due to postcss HOT 3
- [Bug] is it a break change v5.0.5? HOT 4
- [6.0.0] PostCSS missing due to incorrect identification as peerDependency HOT 3
- Incorrect CSS shorthand optimization. HOT 5
- Two audit issues
- PostCSS 8 breaking change in 5.0.7 HOT 8
- TypeError: Cannot read property 'insertAfter' of undefined HOT 3
- Problem in the dependency chain HOT 1
- PostCSS plugin postcss-discard-comments requires PostCSS 8. HOT 2
- affect the other modules when use yarn workspace
- Update cssnano dependency to '^5.0.2' HOT 2
- Could you help remove the vulnerability introduced in your package?
- Upgrade cssnano to resolve dependency vulnerability HOT 1
- How to correct config to fix css duplicated
- Compatibility with webpack>5.0.0 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from optimize-css-assets-webpack-plugin.