Value returned from Lua.FromIntPtr should not be Disposable about keralua HOT 6 CLOSED

You should consider FromIntPtr an "weak reference" do not dispose it.

from keralua.

In this case the returned object should not be marked as disposable. I mean, if an object is disposable then it should be disposed. Since we call a method that returns a disposable object, we are expected to dispose it properly, that's what IDisposable is made for. And it is not obvious that we should not dispose it in such a case. Leaving dangling disposable objects without properly cleaning the resources is a bad practice, I think.

from keralua.

an type that is disposable don't me it SHOULD be disposed, it means it CAN be disposed. Is common practice to to have disposed objects being returned in APIs

For instance in Xamarin.iOS https://learn.microsoft.com/en-us/dotnet/api/uikit.uiview.viewwithtag?view=xamarin-ios-sdk-12 ViewWithTag will return an UIView that is Disposable.

The .NET docs say, you should disposed when you finish using it.

from keralua.

I beg your pardon here for interjecting, but then why is it IDisposable?

I've been thinking the same as the OP, but I also see your explanation that there's no must in that it must be disposed.

Then my question is:
What are the situations when it can be disposed? What is the intended usage pattern when I might have actually disposed it?

from keralua.

It's disposable because the Lua object is disposable. For instance Console.Out return a disposable TextWriter but that doesn't mean you MUST dispose it.

from keralua.

Ah alright, so in this case we're getting the Lua object directly, not just a reference to it.

Then yeah, I guess we shouldn't dispose it.

To answer my own question, as I understand it: we can dispose it if we really want to dispose the Lua VM at this point.

from keralua.