Comments (10)
That seems like a bug it it actually goes like that. With keepCollapsedContent
children should be never destroyed.
Do you have an example to reproduce it? Maybe codepen?
Cheers
from react-collapse.
Reproducing this in code pen is a little different, but i think its related to the same issue:
https://codepen.io/jooj123/pen/qNLXNJ
Notice the 2 unnecessary unmounts:
from react-collapse.
Should be fixed with #72, I am adding this to the list of examples
from react-collapse.
NIce ! looking forward to the big update !
from react-collapse.
Just published react-collapse@next
(not latest
channel yet until better tested) with full rewrite, which fixes this issue. Give it a shot if you are keen.
from react-collapse.
I just checked it out - everything seems to wok correctly except in my use case for some reason the animation has got a bit clunky, any ideas why that my be?
Will try and provide another code pen (and submit another issue) if there is a script tag I can use that has the latest version (not sure if there is)
from react-collapse.
Thanks!
https://npmcdn.com/[email protected]/build/react-collapse.js this would do. I did some more changes, but not published yet (not that it might change the behaviour anyway)
from react-collapse.
re-published newer version https://npmcdn.com/[email protected]/build/react-collapse.js
Probably better to use https://npmcdn.com/react-collapse@next/build/react-collapse.js
from react-collapse.
I was unable to reproduce the issue in codepen - must be related to my code base which has many nested components with each collapse, will be some time until i can find the issue
from react-collapse.
I just wanted to note that I was able to duplicate this issue in a simple scenario with 4.0.3.
The child content gets unrendered on each collapse.
I switched to react-smooth-collapse as a result.
from react-collapse.
Related Issues (20)
- as-prop for Collapse HOT 1
- Fade in/fade out with opacity style on open/close HOT 1
- hasNestedCollapse no longer necessary in v5 yet is used in Nested example HOT 1
- React-collapse does not work on some zoom levels (devicePixelRatio =1.25) Following up #238 HOT 1
- On collapse, .ReactCollapse--collapse element is being completely removed from the DOM
- Animation not working when the Collapse has a parent that it is in modal or something with position fixed HOT 2
- Financing
- The overflow for 'React-collapse--' is overflow:hidden , not overflow:initial for IE11 HOT 2
- Animation doesn't work HOT 5
- Collapse for table row HOT 3
- Starting mix-height HOT 7
- initialStyle not working HOT 3
- Collapse horizontally aligned content HOT 3
- Prop passing suggestion HOT 8
- Block stays expenaded with isOpened=false HOT 4
- Nested collapsible shows animation. Help needed HOT 4
- Collapse/Open all on button click? HOT 1
- Position sticky inside collapse HOT 8
- Is the component still maintained + proposed feature additions HOT 1
- CSS modules in React app won't affect the rendered Collapse HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-collapse.