Giter Club home page Giter Club logo

Comments (3)

nkbt avatar nkbt commented on August 17, 2024

The problem is that when you set state after 50ms you force component to re-render. Collapse then checks "okay, we now do fresh render, we are closed - okay, here is height: 0 then" and therefore it instantly collapses.

This happens because of using defaultStyle here: https://github.com/nkbt/react-collapse/blob/master/src/Collapse.js#L177 There was a reason to use defaultStyle quite a while ago, but it can be probably fixed in some way.

Usually to avoid these issues I keep Collapse isolated from anything except isOpened changes (or its styles) and use shouldComponentUpdate so it does not have any unnecessary re-renders.

Your fix would be to avoid extra unnecessary re-render (that you invoke be setState). Maybe isolating Collapse with extra container or something.

from react-collapse.

nkbt avatar nkbt commented on August 17, 2024

https://jsbin.com/xewacukubo/edit?html,js,output not fixed yet with 2.3.2 =(

from react-collapse.

nkbt avatar nkbt commented on August 17, 2024

Just published react-collapse@next (not latest channel yet until better tested) with full rewrite, which fixes this issue. Give it a shot if you are keen.

from react-collapse.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.