Glitch in DHCP support about ethercard HOT 4 CLOSED

I've written a new dhcp_received_message_type function to replace existing one in dhcp.cpp that scans the option list looking for a the DHCP Message type option. This still works with my setup, but I think its still sending the message type as the first option anyway.
If you want to give this a try and see if it fixes your problems then report back.

Cheers

Andy

Code below:

static bool dhcp_received_message_type (word len, byte msgType) {
    // Map struct onto payload
    DHCPdata *dhcpPtr = (DHCPdata*) (gPB + UDP_DATA_P);

    if (len >= 70 && gPB[UDP_SRC_PORT_L_P] == DHCP_SRC_PORT &&
        dhcpPtr->xid == currentXid ) {

        byte *ptr = (byte*) (dhcpPtr + 1) + 4;
        do {
            byte option = *ptr++;
            byte optionLen = *ptr++;
            if(option == 53 && *ptr == msgType ) {
        // DHCP Message type match found
        return true;
            }
            ptr += optionLen;
        } while (ptr < gPB + len);
    } else {
        return false;
    }
}

from ethercard.

Finally got a chance to give it a try. The new function works in my setup, too. Thanks for the fix!

David

from ethercard.

JCW, if you'd like to include the above as a replacement for the existing function then this should close the issue.

Cheers

Andy

from ethercard.

Thx!

from ethercard.