Comments (8)
Or ofborg labels can have their own namespace
from ofborg.
Sure, no need to hurry. Thanks for all your work, @grahamc!
from ofborg.
This is pretty tough to do. For the near term I could stop adding the python topic tag if you'd prefer.
The reason it is tough is because there are cases where labels should be removed automatically, like when a branch changes to staging and has suddenly a huge diff. ofborg adds tons of labels, then the author rebases against staging and their commits become much smaller. Ofborg then correctly removes all the labels that are not appropriate.
So, the reason this is tough is I think the feature is really: don't remove labels when a person added the label... and that is tough because GitHub's API makes it hard to see this information.
Of course, maybe the right thing is to do is drop topic tagging altogether until I can do that? What do you think?
from ofborg.
cc @FRidh
from ofborg.
from ofborg.
No, please don't drop topic tagging :)
I think you should be able to find out the author by looking at the LabeledEvent
s in the PR's timeline
: https://developer.github.com/v4/object/labeledevent/
Not relabeling labels that were removed manually should be possible using https://developer.github.com/v4/object/unlabeledevent/
from ofborg.
@shlevy if multiple people start searching by borg:topic:python
, there is a tempatation to just set the label manually instead of reminding everyone to search for topic:python
, too.
from ofborg.
True, @dotlambda! I forgot about that! Unfortunately the library I'm using to talk to GitHub (https://github.com/softprops/hubcaps) doesn't support it, so I'd have to first start by implementing that. I don't mind that, but it isn't something I'll be able to do straight away. If you don't mind waiting, I'd be happy to go this route.
from ofborg.
Related Issues (20)
- Always evaluate with `config.allowAliases = false` to avoid deprecation warning errors HOT 2
- python3Packages are not built automatically HOT 4
- Testing functions with "passthru" tests. HOT 2
- `ofborg-eval-check-meta` does not check `meta.hydraPlatforms` properly HOT 3
- aarch64 community box dropping connection to AMQP host
- ofborg-eval-lib-tests sometimes fails at coreutils tests/du/basic HOT 2
- Waiting to run this check... cool. now what? HOT 4
- ofborg should be able to treat aarch64-darwin as x86_64-darwin for builds
- switch hubcap away from fork HOT 2
- Wrong maintainer request HOT 1
- `@ofborg test installer` did not run installer tests, yet succeeded HOT 2
- OfBorg doesn't fail upon encountering an evaluation error for a newly added package HOT 1
- Eval tests should be executed with the lowest supported Nix version (2.3) HOT 4
- vscode label is not automatically set yet HOT 5
- Rebuild labels are wrong for limited platforms
- dead grafana link in project description HOT 2
- PR check doesn't fail even if all `passthru.tests` fail HOT 5
- do the `check-meta` last instead of first
- use `nix build -f .` instead of `nix-build` for better logs HOT 1
- maintainers detected but not pinged? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ofborg.