Comments (8)
I think whoever adds paths should be careful not making the scope to wide. Therefore, I think we should do the same as you currently do with the rebuild tags.
from ofborg.
I could probably do this today. Could you put together an initial mapping of paths to tags?
from ofborg.
Currently all the tags I add already, I remove if they're no longer relevant. ie:
- a PR is created
- it rebuilds 100 packages, I add the rebuild-100 tag.
- a commit is pushed
- now it builds only 10 packages, I remove the rebuild-100 and add the rebuild-10 tag.
In other words, this behavior would also override a human's judgement. Is this desirable, or would you rather these tags be append-only?
from ofborg.
Nix format:
{
# Python-related code and docs
"topic: python" = [
"/pkgs/top-level/python-packages.nix"
"/pkgs/development/interpreters/python"
"/pkgs/development/python-modules"
"/doc/languages-frameworks/python.md"
],
"topic: ruby" = [
"/pkgs/development/interpreters/ruby"
"/pkgs/development/ruby-modules"
],
}
Should we perhaps use glob patterns?
from ofborg.
What would it look like with a glob pattern?
from ofborg.
If I just match *python*
:
./maintainers/scripts/update-python-libraries
./doc/languages-frameworks/python.md
./pkgs/top-level/python-packages.nix
./pkgs/top-level/release-python.nix
./pkgs/development/python-modules
./pkgs/development/libraries/boost/cygwin-1.40.0-python-cygwin.patch
./pkgs/development/libraries/boost/cygwin-fedora-boost-1.54.0-python-unused_typedef.patch
./pkgs/development/libraries/gstreamer/legacy/gst-python
./pkgs/development/libraries/gdal/python.patch
./pkgs/development/interpreters/python
./pkgs/tools/text/unoconv/unoconv-python3.patch
./pkgs/tools/filesystems/ceph/fix-pythonpath.patch
./pkgs/tools/filesystems/glusterfs/glusterfs-python-remove-find_library.patch
./pkgs/tools/package-management/createrepo_c/fix-python-install-path.patch
./pkgs/tools/package-management/python2nix
./pkgs/tools/networking/unbound/python.nix
./pkgs/misc/vscode-extensions/python
./pkgs/misc/frescobaldi/python-path.patch
./pkgs/desktops/gnome-2/bindings/gnome-python
./pkgs/desktops/gnome-2/bindings/gnome-python-desktop
./pkgs/desktops/mate/python-caja
./pkgs/servers/http/apache-modules/mod_python
./pkgs/applications/virtualization/xen/0000-fix-install-python.patch
./pkgs/applications/science/math/sage/spkg-python.patch
./pkgs/applications/networking/instant-messengers/blink/pythonpath.patch
./pkgs/applications/networking/browsers/eolie/0001-Extend-the-python-path-rather-than-replacing-it.patch
The python patches are slightly obnoxious to include, but would be annoying to write code to exclude.
Ruby:
./doc/languages-frameworks/ruby.xml
./pkgs/development/tools/misc/chruby
./pkgs/development/tools/misc/watson-ruby
./pkgs/development/interpreters/jruby
./pkgs/development/interpreters/ruby
./pkgs/development/ruby-modules
./pkgs/tools/text/ruby-zoom
./pkgs/applications/editors/neovim/ruby_provider
./pkgs/applications/audio/rubyripper
from ofborg.
Maybe just checking if a string is contained in the path given by the API?
E.g., say that /pkgs/development/python-modules/numpy/default.nix
is touched. Then doing
pr_path = '`/pkgs/development/python-modules/numpy/default.nix'
tag_path = '/pkgs/development/python-modules'
if tag_path in pr_path:
...
from ofborg.
Ah! Yes, ok, that makes sense. Thanks!
from ofborg.
Related Issues (20)
- Always evaluate with `config.allowAliases = false` to avoid deprecation warning errors HOT 2
- python3Packages are not built automatically HOT 4
- Testing functions with "passthru" tests. HOT 2
- `ofborg-eval-check-meta` does not check `meta.hydraPlatforms` properly HOT 3
- aarch64 community box dropping connection to AMQP host
- ofborg-eval-lib-tests sometimes fails at coreutils tests/du/basic HOT 2
- Waiting to run this check... cool. now what? HOT 4
- ofborg should be able to treat aarch64-darwin as x86_64-darwin for builds
- switch hubcap away from fork HOT 2
- Wrong maintainer request HOT 1
- `@ofborg test installer` did not run installer tests, yet succeeded HOT 2
- OfBorg doesn't fail upon encountering an evaluation error for a newly added package HOT 1
- Eval tests should be executed with the lowest supported Nix version (2.3) HOT 4
- vscode label is not automatically set yet HOT 5
- Rebuild labels are wrong for limited platforms
- dead grafana link in project description HOT 2
- PR check doesn't fail even if all `passthru.tests` fail HOT 5
- do the `check-meta` last instead of first
- use `nix build -f .` instead of `nix-build` for better logs HOT 1
- maintainers detected but not pinged? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ofborg.