Bot that posts pre-defined comments and checklists based on files that are touched or other rules about ofborg HOT 7 CLOSED

Nix could be used for matching as well: https://github.com/NixOS/nix/blob/master/doc/manual/expressions/builtins.xml#L711

I would not invent a new DSL for linting. Our lowest common dominator is Nix already.

from ofborg.

@Mic92 I'd have been inclined to not use a DSL, but just do straight rust 😅

I wonder if we need some sort of database here to match up git patch IDs (https://git-scm.com/docs/git-patch-id) to reviews to ensure comments aren't made multiple times, while still ensuring coverage while a PR changes over time.

Ideally we'd be able to make these comments in-line, so the feedback can be as close to the problem at hand as possible. Is this too ambitious?

from ofborg.

Maybe for now limit the rules to just paths, as we do with the tags in #59. In that case one or more paths will produce one or more comments.

If we use a mapping, and use the paths as keys, then we may have to duplicate comments a lot. If we use a list of tuples that may be reduced. For this I think it is better to use Nix.

from ofborg.

Ideally we'd be able to make these comments in-line, so the feedback can be as close to the problem at hand as possible. Is this too ambitious?

I would start of with just only comments based on touched files, and thus post the comments to the main thread.

from ofborg.

This likely isn't in ofborg's scope.

There's probably an action that already does this.

from ofborg.

Hmm well there is https://github.com/NixOS/ofborg/blob/released/ofborg/src/bin/github-comment-poster.rs and githubcommentposter but I haven't seen a comment posted by ofborg in a long time. Will let someone else decide.

from ofborg.

Yes, ofborg doesn't post comments anymore. The name is a relic, but that binary is what currently posts the GHA checkruns (ofborg-eval, ofborg-eval-package-list, etc).

from ofborg.