Custom print command about tableprint HOT 4 OPEN

Happy to accept a PR for this!

from tableprint.

You can already pass a custom object for IO using the out keyword argument to table and TableContext. By default, this is sys.stdout, but it can be a file handle or any other object that has a write(str) method and a flush method. (This is exactly like the output_stream argument in tf.print).

I don't really want to add in custom logic for TensorFlow, but if you want the output to go through a tf.print call you can use a shim class like follows:

class TFWriter:
  def write(self, s):
    tf.print(s)
  def flush(self):
    pass

tp.table(data, headers, out=TFWriter())

from tableprint.

Thanks—the shim you wrote is pretty clever; I didn't think of that!

To be honest, I don't remember if I knew about the out argument—regardless, I should've mentioned that since I want to progressively print, I can't use out, as I need to use tp.header and tp.row, neither of which accept an out argument.

If you're okay with header and row accepting the out argument, I may be able to write a PR for this within the next two weeks.

from tableprint.

Currently, header and out both return strings, which need to be printed by the user. If we want to add the out argument, it makes sense to return None, like the other methods, and print using out. However, I'd consider this a breaking change.

We can:

• make out default to None, and if out is not None, then use out to print; else, don't print anything and return a string. This avoids a breaking change, as users who currently don't use the out argument won't experience any problems, and I'll be able to use the shim you wrote. However, I'm not a fan of this—IMO, these functions should either print or return a string in all cases, to avoid user confusion.
• make out default to sys.stdout, like the other functions. This means we should not return anything, and print using out. I like this behavior, as IMO it's more intuitive than the first option, but causes a breaking change, since users who don't currently use the out argument will be printing None along with tableprint's output.

What do you think? Honestly, I think tableprint is ready for a 1.x release, so I don't have a problem with causing a breaking change and bumping the major version.

from tableprint.