Giter Club home page Giter Club logo

Comments (5)

nipunn1313 avatar nipunn1313 commented on August 22, 2024

Thanks @moshe - I think this is a better question for @dzbarsky - so shooting over.

We do use bazel, but the way it fits into our system isn't straightforward to extract directly into a BUILD file here. Would be happy to take a contribution here if you have one that works for you.

from mypy-protobuf.

dzbarsky avatar dzbarsky commented on August 22, 2024

@moshe Hi, are you looking for a build file to build the go binary itself, or a fuller integration to run the generation process within the bazel build itself (i.e. write the generated pyi files into runfiles)?

from mypy-protobuf.

moshe avatar moshe commented on August 22, 2024

Hi @dzbarsky, @nipunn1313, Thank you for your time
I dug in a little deeper and ended up opening a PR for making the protobuf python rule to accept external plugins - protocolbuffers/protobuf#7056
But in addition, I struggled to make bazel run the go implementation due to the folder structure of the project
A BUILD example of running the go plugin will be great ๐Ÿ™‚

from mypy-protobuf.

dzbarsky avatar dzbarsky commented on August 22, 2024

Got it. As a quick disclaimer, we actually don't use the upstream protobuf python rules, so we can't help with that bit, but it sounds like you've got it covered.

The current process of open-sourcing the go generator is pretty manual so it actually isn't fully up to date in the repo. I'm doing a bit of work today/tomorrow to improve that, after which it should show up in https://github.com/dropbox/dbx_build_tools complete with the BUILD files necessary. You should be able to add that repo as an external workspace and point to the binary rule.

Hope that's what you were looking for, and will update this thread once that's complete!

from mypy-protobuf.

dzbarsky avatar dzbarsky commented on August 22, 2024

@moshe https://github.com/dropbox/dbx_build_tools/blob/master/go/src/dropbox/build_tools/protoc-gen-mypy/BUILD is the rule we use to compile the generator. If you pull in our repo as a workspace you can refer to it as @dbx_build_tools//go/src/dropbox/build_tools/protoc-gen-mypy, hope that helps!

from mypy-protobuf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.