View is hidden by the stopAnimation method? about nvactivityindicatorview HOT 8 CLOSED

@whisper-bye: Just checked the code

public func stopAnimation() {
    self.layer.sublayers = nil
    self.animating = false
    if hidesWhenStopped && !hidden {
        hidden = true
    }
}

When stopAnimation() is called, it removes all sublayers. That is why the view looks like hidden regardless hidesWhenStopped. Anyway, I will refine this method and behavior, but PR is always welcome.

from nvactivityindicatorview.

@whisper-bye: I've decided to remove hidesWhenStopped in next major release (3.x). The expected behavior now should be that before starting and stopping animating, nothing should be appeared but its background color. Also considering to hide the view itself before starting and after stopping.

from nvactivityindicatorview.

@ninjaprox
Thanks for your work. I will check it out later.

from nvactivityindicatorview.

@ninjaprox For some reason, my indicator does not hide when i call self.activityIndicator.stopAnimating()

UPDATE:
Nevermind, lousy programming from yours truly 😅

from nvactivityindicatorview.

@otymartin: What could I do to improve it?

from nvactivityindicatorview.

@ninjaprox it's perfect actually, I haven't had any problems with it at all. One usecase I'm going to attempt (It may be outside the focus scope) is at startAnimating -> I would like to automatically blur the view below. I use this library for video so while buffering, it makes for a nice effect.

Thanks alot for the library btw 💯

from nvactivityindicatorview.

@otymartin: Thanks! Perhaps I think that's good idea to add. I will try, PR is welcome though. 😄

from nvactivityindicatorview.

@ninjaprox I would but Im too new to swift & github (programming in general)😫🙈

from nvactivityindicatorview.