estimateMaxWorkspaceSize() is too small about compress HOT 9 CLOSED

Thank you for reporting this. Sounds like a bug indeed, will fix.

from compress.

Trying to fix this but goddang $#%(($#^)$#^$# TestNG is trying to prevent any work, failing in new spectacular ways. Almost tempted to convert test suite to junit...

Other than that, added test and will try to figure out what's wrong with the logics.

from compress.

Ok so size estimation is slightly broken since rounding down of 1 << 5 and 1 << 6 misses one byte needed as length indicator for shortest; and probably can affect things up to 2 chunks. So I think I'll fix problem wrt shortest chunks with just adding 2.

But I also noticed sort of reverse issue: estimates are too big for larger input, so I'll tackle that as well.

from compress.

Looks like I don't have write access any more, no doubt due to Ning's reorg.
I'll have to see if I can find someone to give access, or if I'll have to fork this repo.
Sigh.

from compress.

You should have access again now :) Looks like someone went through and pruned out all the 'trusted external' accounts except for a couple of us.

from compress.

@myelin Thanks! Yes, understandable. Just hadn't noticed before.

from compress.

Pushing 1.0.4 release now with fixes.

from compress.

@cowtowncoder thank you for this fantastically quick fix and release!

from compress.

@leventov Thank you for reporting this!

from compress.