:gun_http.ws_send/6 is undefined or private about gun HOT 9 OPEN

Cheers. If that's it please leave the ticket open and I'll make sure Gun avoids this crash.

from gun.

There's no ping in HTTP so that might be why this happens. How do you send pings?

from gun.

@essen thsi is the code I have that does it. the traceback is non exsitant but this is the only place I send {:ping, "ping"} so I assume this is where it slips into the library

  def handle_cast({:send_message, "ping"}, %{name: name, stream_ref: stream_ref, gun_pid: gun_pid} = state) do

    case :gun.ws_send(gun_pid, stream_ref, {:ping, "ping"}) do
      :ok ->
        {:noreply, state}
      reply ->
        {:noreply, state}
    end
  end

and this is occurring over a websocket

from gun.

The 6-arity is an internal call that results from yours. What might be a bug is if you try to send a Websocket ping when the connection is using HTTP, it tries to call a function that does not exist instead of rejecting the call.

from gun.

hmm ok so what it uses depends conditionally on if the websocket handshake is established?

from gun.

ok so I added a guard clause that prevents the ws_send from sending the ping unless the status of the websocket is successfully upgraded. will let you know if it works.

Thankyou for the insight!

from gun.

unfortunately I am still seeing it after the guard clause was added.

from gun.

I got the same crashes. It happens when gen_statem in e.g connected state receives {ws_send, frames()} but the protocol is gun_http which doesn't have a ws_send function. Depending conditionally on ws handshake doesn't solve the issue due to the async nature there is no guarantee gun will not reconnect having {ws_send, frames()} in the mailbox. It is easily reproducible just by calling gun:ws_send/3 and reconnecting.

from gun.

Good point. Should handle that better.

from gun.