[RFC] Credo rules about elixir-templates HOT 4 CLOSED

I am more in favor in enforcing usage of aliases as it helps to clearly see the dependencies of each module at the top of the file. Also, it would be better to consistently use aliases and not on a case by case basis.

Based on the example:

# Better
defmodule MyApp.Web.Search do
  alias MyApp.External.TwitterAPI

  def twitter_mentions do
    TwitterAPI.search(...)
  end
end

# Less good
defmodule MyApp.Web.Search do
  def twitter_mentions do
    MyApp.External.TwitterAPI.search(...)
  end
end

from elixir-templates.

Thanks @olivierobert
Let's go with your suggestion for AliasUsage. I have updated #3 appropriately.

from elixir-templates.

Hi @Tolsee @olivierobert the AliasUsage seems didn't update in https://github.com/nimblehq/elixir-templates/pull/3/files#diff-78b22540b368040b6266f21dc737a6baR75 so I think to bring this issue up cc @rosle @bterone @hanam1ni

We would need to look at 2 topics

1/ Using credo --strictmode
2/ Improve the .credo.exs in priv/templates/nimble.phx.gen.template/.credo.exs

from elixir-templates.

Implemented in #31

from elixir-templates.