Fix cloning of MultiNiftiMasker in MultiPCA about nilearn HOT 6 CLOSED

In MultiPCA, if the user provides a masker, we clone it. Unfortunately, in
joblib 0.6, a bug prevent cloning a Memory object.

I don't understand. The memory shouldn't be cloned, only the masker. What
is the error message? Sorry, I am supposedly listening to talks, so I
cannot reproduce myself.

G

from nilearn.

The Masker contains a Memory object. Therefore, when we clone the masker, the Memory is cloned too. Unfortunately, in joblib 0.6, cloning a Memory does not work if cachedir is None.

Philippe's patch fixes this bug but it breaks Travis build :-/

from nilearn.

The Masker contains a Memory object. Therefore, when we clone the masker, the
Memory is cloned too. Unfortunately, in joblib 0.6, cloning a Memory does not
work if cachedir is None.

OK, I remember now.

Philippe's patch fixes this bug but it breaks Travis build :-/

OK, you can do a try/except on the cloning of the masker rather than
testing for version.

G

from nilearn.

Yes, this is what I've done for the moment. I opened this issue to remember to look for a cleaner fix if it exists (ie use Philippe's patch while keeping Travis build functional).

from nilearn.

I don't think there is any need for a "clean" patch: this is a workaround, and such things are always a little messy. If the code inside the "try" branch is clean, that doesn't matter to me if what is in the "except" clause is ugly. Using a try/except by itself is not bad practice.

from nilearn.

Okay then. I close this issue !

Fixed in 9f5b3e8

from nilearn.