dualsync() should return a jQuery promise (or Deferred) about backbone.dualstorage HOT 4 OPEN

I like this idea.

from backbone.dualstorage.

I do this with following code

  # dualSync Promise adapter
  Backbone.dualSync = Backbone.sync
  Backbone.sync = (method, model, options) ->
    result = Backbone.dualSync.apply(this, arguments)
    if result.then
      result
    else
      # localSync never fails, so we return success promise
      (new $.Deferred()).resolve(result).promise()      

The main question is if it's true that localsync never fails. Better approach would be to wrap localSync into Promise properly

from backbone.dualstorage.

I do it with a fetch override

  fetch: =>
    $.Deferred((deferred) => super
      success: deferred.resolve
      error: deferred.reject).promise()

from backbone.dualstorage.

I believe dualsync will already return the jQuery xhr promise when online, and we only need to create a new promise when localsync handles the sync by itself. I'll write some specs to make sure this is true.

from backbone.dualstorage.