Giter Club home page Giter Club logo

Comments (4)

nikivanstein avatar nikivanstein commented on July 19, 2024 1

Thank you for the comments!
I will check and update the numpy conflict, we can just take the shap version and remove it in the requirements.
Good point about the readme, will clean it up a bit and will add some example images.

I used the citation syntax that the packages themselves provided, the paper uses a bibtex file, so I guess the style there is standardized no? Will check and update.

Plot functions are not that useful to automatically test I think, running the demo and checking the output basically shows that they are all working. In the tests I could check if the files exist but I don't think that it adds much. The rest of the functions is covered.

from gsareport.

nikivanstein avatar nikivanstein commented on July 19, 2024 1

Indeed, well spotted. Moved the References section to the end and called that section Related software.

from gsareport.

nikivanstein avatar nikivanstein commented on July 19, 2024

I have updated the readme and made it more clear for developers, pointing to the documentation to avoid duplication.

I have fixed the paper bibtex and citation style and resolved the numpy version conflict.

Hope you like it :)

from gsareport.

Saran-nns avatar Saran-nns commented on July 19, 2024

Thanks for considering my suggestions. I think there is an issue with the Reference title location in the paper. Shouldn't be at line 54? Otherwise all looks good now :)

from gsareport.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.