Comments (4)
Niels-IO
commented on June 30, 2024
Hi @joseph-bayer,
Thank you very much for your nice words!
I am sorry but I cannot spot where the imageSizes are not reflected. The numbers in the CLI output seems to be the ones in the next.config.
Could you help me understand?
from next-image-export-optimizer.
joseph-bayer
commented on June 30, 2024
@Niels-IO
Oh wait… is it exporting images for all the numbers in both the imageSizes and deviceSizes arrays? I assumed it was just pulling the sizes from the imageSizes array. Because of that assumption, I thought the next-image-export-optimizer process was creating more images than necessary.
from next-image-export-optimizer.
joseph-bayer
commented on June 30, 2024
@Niels-IO - I just checked the optimization code and realized that it’s pulling the image sizes from both the imageSizes and deviceSizes arrays (and also cleverly generating a 10px image to use for the placeholder).
It looks like everything is working correctly. Thanks again for all the work you’ve put into this!! 😄
from next-image-export-optimizer.
Niels-IO
commented on June 30, 2024
Hi @joseph-bayer,
No worries! I kept the same logic as Next.js and they use also two arrays which then together form the array of sizes.
I am happy that the library is useful!
from next-image-export-optimizer.
Related Issues (20)
- Personalize file names HOT 3
- Package wont install on NPM with Next 14 HOT 1
- Using remote SVGs HOT 1
- Feature request: Don't download again for X days HOT 4
- process.env.nextImageExportOptimizer_storePicturesInWEBP assumed to be boolean HOT 1
- Next.js 14 dev mode error HOT 2
- Images that dont have predefined height HOT 8
- SVG optimization with tools like svgo HOT 2
- Can't optimize two different path HOT 1
- unexpected property: transpilePackages HOT 4
- Srcset not created for Static Images HOT 28
- Output folder not being created on build. HOT 12
- Add support for Picture element HOT 1
- Issue with query string get params HOT 2
- Could not load sharp module error HOT 2
- Export utilities from ExportedImage component HOT 1
- Allow setting location of the hashes.json and optimized images
- Add `unoptimized` configuration option
- Adding custom options when fetching remote images HOT 4
- Doesn't work on next 14.1 HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from next-image-export-optimizer.