Trigger activity switching only if current state changed about homebridge-harmony HOT 14 CLOSED

Hi,

thank you for the feedback. It is indeed a problem :) I will take a look at it.

from homebridge-harmony.

hi,
@carsten-h
@det-box

In 0.0.8 you MUST add a config key like this even if you don't want to use the option :
"skipedIfSameStateActivities" : []

I will fix this in the next version (in order to make it optionnal), as well as being able to include all activites by default. - see #21

from homebridge-harmony.

Perfect, if you need support then tell me.
Thx❗️

from homebridge-harmony.

I think we have 3 options there :

• either adding a global option like that was made - not very "fan" of that, since you might want different behaviors depending on the scene (especially for the "turn off TV" one while using siri if you are on another scene,
• either setting an option per activity (some parameter with a list of scene to have this behavior)
• or maybe we could decide of the beahivour automatically if the scene has at least one device that doesn't have 2 IR command for on / off.

What do you think ?

from homebridge-harmony.

I think point 2 would not be bad. Point 3 sounds good too. But I can not really judge what is technically best implemented. 😕

from homebridge-harmony.

Hi,

@Nastras : Let's give a try to the latest version and tell me if it suits your needs :)

https://github.com/nicoduj/homebridge-harmony/releases/tag/0.0.8

from homebridge-harmony.

Hello @nicoduj, thanks for fixing it. I have tested it quickly and so far everything works fine. I'll call you tomorrow after a long test again .-)

Greeting Nastra

from homebridge-harmony.

Hi,
After updating to version 0.0.8 , the hombridge reboots when activating an action
error:
Jan 7 18:32:12 hbridge3 homebridge[21296]: /usr/local/lib/node_modules/homebridge-harmony/index.js:460 Jan 7 18:32:12 hbridge3 homebridge[21296]: this.skipedIfSameStateActivities.includes( Jan 7 18:32:12 hbridge3 homebridge[21296]: ^ Jan 7 18:32:12 hbridge3 homebridge[21296]: TypeError: Cannot read property 'includes' of undefined Jan 7 18:32:12 hbridge3 homebridge[21296]: at HarmonyPlatform.<anonymous> (/usr/local/lib/node_modules/homebridge-harmony/index.js:460:44) Jan 7 18:32:12 hbridge3 homebridge[21296]: at Characteristic.On.emit (events.js:188:13) Jan 7 18:32:12 hbridge3 homebridge[21296]: at Characteristic.On.Characteristic.setValue (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/lib/Characteristic.js:320:10) Jan 7 18:32:12 hbridge3 homebridge[21296]: at Bridge.<anonymous> (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/lib/Accessory.js:871:22) Jan 7 18:32:12 hbridge3 homebridge[21296]: at Array.forEach (<anonymous>) Jan 7 18:32:12 hbridge3 homebridge[21296]: at Bridge.Accessory._handleSetCharacteristics (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/lib/Accessory.js:811:8) Jan 7 18:32:12 hbridge3 homebridge[21296]: at HAPServer.emit (events.js:188:13) Jan 7 18:32:12 hbridge3 homebridge[21296]: at HAPServer._handleCharacteristics (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/lib/HAPServer.js:972:10) Jan 7 18:32:12 hbridge3 homebridge[21296]: at HAPServer.<anonymous> (/usr/local/lib/node_modules/homebridge/node_modules/hap-nodejs/lib/HAPServer.js:209:39) Jan 7 18:32:12 hbridge3 homebridge[21296]: at IncomingMessage.emit (events.js:188:13) Jan 7 18:32:12 hbridge3 systemd[1]: homebridge-harmony.service: Main process exited, code=exited, status=1/FAILURE Jan 7 18:32:12 hbridge3 systemd[1]: homebridge-harmony.service: Unit entered failed state. Jan 7 18:32:12 hbridge3 systemd[1]: homebridge-harmony.service: Failed with result 'exit-code'. Jan 7 18:32:22 hbridge3 systemd[1]: homebridge-harmony.service: Service hold-off time over, scheduling restart. Jan 7 18:32:22 hbridge3 systemd[1]: Stopped Node.js HomeKit homebridge-harmony. Jan 7 18:32:22 hbridge3 systemd[1]: Started Node.js HomeKit homebridge-harmony.

Version 0.0.7 does not do that

from homebridge-harmony.

Hello!

I have the same problems like det-box here. I didn't change the config from 0.0.7 to 0.0.8:
{ "platform": "HarmonyHubWebSocket", "name": "HarmonyHub", "hubIP": "192.168.178.106", "showTurnOffActivity": true, "turnOffActivityName": "Medienruhe", "refreshTimer": 30 },

After switching back to 0.0.7 everything is working fine!

from homebridge-harmony.

Being able to have a setting to include everything in skippedIfSameState would be nice, since that is how I would use it.

from homebridge-harmony.

Sorry, the error was due to wrong configuration

from homebridge-harmony.

Yes, this is correct, adding the option "skipedIfSameStateActivities" is working fine!

Thank you!

from homebridge-harmony.

@Sunoo : check latest version, I have added the option you were asking for.

from homebridge-harmony.

It works for me 👍

from homebridge-harmony.