Giter Club home page Giter Club logo

Comments (13)

nickzman avatar nickzman commented on September 25, 2024 1

The glViewport() needs to be set to the view bounds * the view's window's screen's backingScaleFactor. And then -wantsBestResolutionOpenGLSurface needs to be always turned on so the viewport is correct in Mojave and earlier.

If it just doesn't work at 2x for whatever reason, then at the least, disabling -wantsBestResolutionOpenGLSurface will fix the viewport problem.

from helios.

TimAlberry avatar TimAlberry commented on September 25, 2024 1

Awe...some!

from helios.

nickzman avatar nickzman commented on September 25, 2024 1

You don't need access. You create PRs on Github by forking a project, checking in your changes, and then creating a PR against the master repository.

from helios.

nickzman avatar nickzman commented on September 25, 2024

I know, and it's because Apple changed OpenGL views in Catalina so they expect the viewport to draw at 144 DPI instead of 72 on a HiDPI display, and this is what happens if it's programmed to run at 72 and rely on the old default behavior.

I can either enforce the old behavior, or make sure it works with HiDPI if I can find the time.

from helios.

erango avatar erango commented on September 25, 2024

I really want this to work :D If you can point me in the right direction I can make a PR

from helios.

TimAlberry avatar TimAlberry commented on September 25, 2024

I don't know what a PR is (I am not a developer), but a fixed version of what is in my humble opinion the most hypnotic screensaver ever, especially this late in the day... would be... wonder-full. 1.6?

from helios.

erango avatar erango commented on September 25, 2024

It's been about 10 years since I last did anything with C++ but I'm setting up an environment and doing this. I love it too and I want it to be perfect on retina screens too 😄

from helios.

erango avatar erango commented on September 25, 2024

OK, I'm good to go. Ready to make a PR, also have a working build. @nickzman Would you like to give me access to contribute?

from helios.

erango avatar erango commented on September 25, 2024

Cool! Never done it like that before.

from helios.

TimAlberry avatar TimAlberry commented on September 25, 2024

How are things progeessing on this? Or maybe fix has been released somewhere else that I have missed (as I see mention of "forking" in earleir posts)?

from helios.

nickzman avatar nickzman commented on September 25, 2024

I've completely revamped the screen saver by bringing the code base up to date with the Windows version, and modernizing the product and the build. The latest changes add HiDPI and 60 FPS support. If you have Xcode 11.x, please try it out. Otherwise, I'll have binaries out soon.

from helios.

TimAlberry avatar TimAlberry commented on September 25, 2024

I hope everyone on this thread is keeping safe. And I also wondered if there is any news on creation of the binaries (as I know zip about Xcode 11! ;)

from helios.

nickzman avatar nickzman commented on September 25, 2024

The binaries came out two weeks ago.

from helios.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.